[Mplayerplug-in-devel] [PATCH] fix for apple/trailers crash

[Avi R. <avi...@gm...>]

Hi,

Since the beginning of last month I can't access any movie trailer on
apple.com - I get a segmentation fault as soon as the link to the .mov
file is accessed.

For reference: I'm running Debian/testing, Iceweasel 3.0.9 (unbranded
firefox), Debian packaged v 3.55  of mplayer plugin, and mplayer
1.0.rc2svn20090412 (packaged by debian-multimedia.org).

This seems to have already been reported as Ubuntu bug #360222 [1], and
Arch Linux bug #14155 [2].

I get the following typical output when running from a terminal:

ADDED URL: harrypotterhalfbloodprince-tlr4b_h640w.mov
code: 42
 speed -1

and then the segfault.

I used this text as a starting point for debugging and luck was on my
side :-)

The crash happens at plugin-list.cpp, line 414, during the call to
memmem. The cause is a typo in the exit condition at line 411 - 'p'
appears instead of 'buffer' (see attached patch), so that we get to line
414 even if there's no next "rmda" (consider lines  348, 418). All line
numbers refer to the code from the daily snapshot.

I'm guessing that something must have changed at apple.com to trigger
this specific code path. In any case, the patched plugin seems to work
nicely at my end.

Cheers,
Avi.

[1] https://bugs.launchpad.net/bugs/360222
[2] http://bugs.archlinux.org/task/14155