#104 switching mms:// to http:// breaks some media

closed-fixed
Plugin (92)
5
2006-07-14
2006-06-14
Ari Pollak
No

From Debian bug report http://bugs.debian.org/373612:

Version: 3.25-7

It misinterprets mms://... to http://... (confirmed
with 'debug=1'
option), preventing media to play well. When taking URL
into playlist or
copying URL, it works well and gets 'mms://...'.

No such bug in older version (3.21-1).

Reproduce : Go to the URL below. It may not work after
3-4 days.
http://www.goclassic.co.kr/wma/play.html?image=http://image.allmusic.com/00/acg/cov200/cl000/l079/l07928yuuv7.jpg&src=PT1nTXRsM2N6MVdZb0puUQ==&discouid=2452&provided=lilly0126

Discussion

  • Kevin DeKorte

    Kevin DeKorte - 2006-06-14

    Logged In: YES
    user_id=685413

    Can you try the daily code drop? A recent change was made to
    try http:// then mms:// and then mmst:// protocols when
    given an mms:// URL. This is done because some sites give
    higher quality media from the http:// url

    the sample URL does not work.

     
  • Ari Pollak

    Ari Pollak - 2006-06-15

    Logged In: YES
    user_id=41611

    Out of curiosity, which file was changed? I can't find the
    change in CVS.

     
  • Kevin DeKorte

    Kevin DeKorte - 2006-06-15

    Logged In: YES
    user_id=685413

    plugin-threads.cpp around line 1463, what I tried to do is
    first I switch from mms:// to http:// (line 1856 mmsToHttp)
    and then if it doesn't work I try mms:// and then finally to
    mmst://

    if (result->tryagain == TRYAGAIN_FALLBACK) {
    //fallback to msst if we can
    strlcpy(url_copy, local_url, 1023);
    url_copy[1023] = '\0';

    if (strncmp(local_url, "mms://", 6) == 0) {
    snprintf(local_url, 1023, "mmst://%s", url_copy + 6);
    result->retval = TRUE;
    } else if (local_mmsstream &&
    strncmp(local_url, "http://", 7) == 0) {

    snprintf(local_url, 1023, "mms://%s", url_copy + 7);
    result->retval = TRUE;
    } else {
    result->retval = FALSE;
    }
    }

     
  • Ari Pollak

    Ari Pollak - 2006-06-16

    Logged In: YES
    user_id=41611

    Oh, that's in 3.25, which is why there seems to be a problem
    in the first place. Supposedly this works fine in 3.21.

     
  • Kevin DeKorte

    Kevin DeKorte - 2006-06-16

    Logged In: YES
    user_id=685413

    Ok, the part that works fine in 3.21 is that the mms urls
    are not converted to http urls. That change was made in 3.25
    because certain sites give higher quality media over the
    http URL... see www.arenafootball.com. The code that shifts
    the HTTP url back to the mms url if there is a problem is
    added in CVS.

    I wish I could see the output of the original test case,
    because without seeing what is going on, I can't debug the
    situation. Every website out there has quirks, I wish it
    could be standardized a little.

    Did you ever have the original bug reported try the current
    CVS code? I tried to duplicate the report, but the original
    website is in Korean, and I can't read it to know what to do.

     
  • Nobody/Anonymous

    Logged In: NO

    The part of plugin-threads.cpp you're describing was already
    changed in 3.25, and the media originally worked with 3.21.

     
  • Kevin DeKorte

    Kevin DeKorte - 2006-06-20

    Logged In: YES
    user_id=685413

    I still need a test case so that I can debug this issue.
    Without a test case this issue will not be fixed as the
    current setup works for me on the sites I use.. ie CNN etc...

     
  • Ari Pollak

    Ari Pollak - 2006-06-20

    Logged In: YES
    user_id=41611

    Is the provided URL not good? If you go to it and it tries
    to play in mplayerplug-in, it just appears stopped. But if
    you copy the URL and open it in mplayer directly, it works fine.

     
  • Kevin DeKorte

    Kevin DeKorte - 2006-06-20

    Logged In: YES
    user_id=685413

    Well I made a change to CVS to help with the http->mms->mmst
    url rotation selection. However, I still cannot make the
    testing URL work from the command line.

    Running mplayer mms://211.62.35.170/classic2/Brhamssym2.wma

    Gives me a File not found message... it looks like an
    mplayer error at this point. I am running mplayer cvs

     
  • Ari Pollak

    Ari Pollak - 2006-06-20

    Logged In: YES
    user_id=41611

    Hm, that's weird. It was just working a second ago.

     
  • Kevin DeKorte

    Kevin DeKorte - 2006-06-20

    Logged In: YES
    user_id=685413

    Can you grab the CVS code, set debug=1 and run firefox with
    the above URL and send me the output. I would like to see if
    my patch worked... I have updated the daily code drop so if
    CVS is out of date you can get the patch from there.

     
  • Kevin DeKorte

    Kevin DeKorte - 2006-06-29
    • status: open --> pending-fixed
     
  • Kevin DeKorte

    Kevin DeKorte - 2006-06-29

    Logged In: YES
    user_id=685413

    Switching to pending, since there has been no feedback.
    However, I do believe current CVS fixes this problem.

     
  • SourceForge Robot

    Logged In: YES
    user_id=1312539

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     
  • SourceForge Robot

    • status: pending-fixed --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks