#16 mpg321 does not close files it plays

Joe Drew

I'm running mpg321 with remote interface. Every time I load new song via L <filename>, new descriptor is opened and the previous left open causing "too many open files" error eventually.
I corrected this with adding "close(fd); fd=0;" after munmap() in mpg321.c, but I'm not sure, whether it is currect way how to do it. Nevertheless it works :)


  • Jacob Lee Anawalt

    Logged In: YES

    I checked out from CVS tonight (2002/12/06) and it seems
    you've put the close(fd) call in after munmap() as noted
    above. I'll try it on a repeating random playlist that was
    dying after oh 1024 songs.

    The autoconfigure (I'm not at all skilled in those yet) made
    an empty config.h file, so I had to grab the values from
    config.log for the following three defines before I could

    #define AUDIO_DEFAULT "the libao default"
    #define RETSIGTYPE void
    #define VERSION "0.3.0"

    I'd be glad to email any config files if you weren't already
    aware of this and it works on your system. 'It doesn't
    happen on my system'(tm)

  • Joe Drew

    Joe Drew - 2002-12-08

    Logged In: YES

    I can't explain the configure issue, but the fd issue has
    been fixed for some time. I've been without a computer for a
    while though, so I wasn't able to respond to this.

    If you want to open a new bug for configure not working,
    please do, and attach config.log. Thanks :)

  • Joe Drew

    Joe Drew - 2002-12-08
    • status: open --> closed-fixed

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

No, thanks