#12 seg fault in id3_get_tag in v0.2.9

closed-out-of-date
nobody
None
5
2002-03-24
2002-03-24
David Meyer
No

The following:

((maxlen - strlen(printable)) > 0) ? (tocopy = (maxlen -
strlen(printable))) : (tocopy = 0);

is wrong. maxlen and strlen(printable) are both
unsigned, so if, e.g., maxlen is 30 and
strlen(printable) is 31, then tocopy is going to end up
equal to 4294967295, which won't work well. The
attached patch should fix this.

Discussion

  • Joe Drew

    Joe Drew - 2002-03-24

    Logged In: YES
    user_id=330927

    Not to steal your thunder, but I've already fixed this in
    CVS. :) Look for a 0.2.10 with this and other fixes very soon.

    Thanks a lot!

     
  • Joe Drew

    Joe Drew - 2002-03-24
    • status: open --> closed-out-of-date
     
  • Joe Drew

    Joe Drew - 2002-03-24

    Logged In: YES
    user_id=330927

    On second thought, I've implemented your fixes in my fixes
    as well. I'm not positive on whether they're needed, but
    they're definitely safer.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks