#368 Build fail with portable mode

[Vampire Frog]

Cannot compile with these flags:

vampi:~/Code/ttsclient/mpg123-1.32.4$ ./configure --disable-shared --enable-static --disable-components --enable-libmpg123 --disable-id3v2 --disable-string --disable-icy --disable-32bit --disable-layer2 --disable-layer1  --enable-portable --with-cpu=generic_float --with-audio=dummy --disable-equalizer && make
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a race-free mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for -Werror in CFLAGS (It breaks tests)... no
checking if you are up to something totally static with LDFLAGS/CFLAGS... no
checking whether make supports the include directive... yes (GNU style)
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether the compiler supports GNU C... yes
checking whether gcc accepts -g... yes
checking for gcc option to enable C11 features... none needed
checking whether gcc understands -c and -o together... yes
checking dependency style of gcc... gcc3
checking dependency style of gcc... gcc3
checking for gcc... (cached) gcc
checking whether the compiler supports GNU C... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to enable C11 features... (cached) none needed
checking whether gcc understands -c and -o together... (cached) yes
checking dependency style of gcc... (cached) gcc3
checking how to run the C preprocessor... gcc -E
checking for cos in -lm... yes
checking for library containing clock_gettime... none required
checking for clock_gettime... yes
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for an ANSI C-conforming const... yes
checking for inline... inline
checking for stdio.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for strings.h... yes
checking for sys/stat.h... yes
checking for sys/types.h... yes
checking for unistd.h... yes
checking whether byte ordering is bigendian... no
checking for windows.h... no
Modules disabled, not checking for dynamic loading.
checking how to print strings... printf
checking for a sed that does not truncate output... /usr/bin/sed
checking for fgrep... /usr/bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking how to convert x86_64-pc-linux-gnu file names to x86_64-pc-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-pc-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for a working dd... /usr/bin/dd
checking how to truncate binary pipes... /usr/bin/dd bs=4096 count=1
checking for mt... mt
checking if mt is a manifest tool... no
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... no
checking whether to build static libraries... yes
Modules disabled.
configure: WARNING: ID3v2 support disabled because of string API being disabled.
We assume IEEE754 floating point format.
checking if .balign is present... yes
checking __attribute__((aligned(16)))... yes
checking if assembler supports AVX instructions... yes
checking for basic C99 features... yes
checking for unistd.h... (cached) yes
checking for sched.h... yes
checking for sys/ioctl.h... yes
checking for sys/types.h... (cached) yes
checking for sys/time.h... yes
checking for sys/wait.h... yes
checking for sys/resource.h... yes
checking for sys/signal.h... yes
checking for signal.h... yes
checking for sys/select.h... yes
checking for dirent.h... yes
checking for sys/stat.h... (cached) yes
checking switched off_t size... 8
checking size of off_t... 8
checking if native off_t is already 64 bits... yes
checking for mmap... yes
checking POSIX termios... yes
checking if we have wincon.h... no
checking for random... yes
checking for setenv... yes
checking for unsetenv... yes
checking for sched_setscheduler... yes
checking for setuid... yes
checking for getuid... yes
checking for setpriority... yes
checking for strerror... yes
checking for strerror_l... yes
checking for uselocale... yes
checking for setlocale... yes
checking for nl_langinfo... yes
checking for mbstowcs... yes
checking for wcstombs... yes
checking for wcswidth... yes
checking for iswprint... yes
checking for atoll... yes
checking for mkfifo... yes
checking for fork... yes
checking for execvp... yes
checking for ctermid... yes
checking for locale.h... yes
checking for langinfo.h... yes
checking for wchar.h... yes
checking for wctype.h... yes
checking for netdb.h... yes
checking for sys/param.h... yes
checking for sys/socket.h... yes
checking for netinet/in.h... yes
checking for arpa/inet.h... yes
checking for library containing gethostbyname... none required
checking for library containing socket... none required
checking for getaddrinfo... yes
checking for sqrt in -lm... yes
checking for powf in -lmx... no
checking for byteswap.h... yes
checking for os2.h... no
checking if we want feature report function... yes
Limiting outputs to build according to your preference: dummy
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking if you are too dumbing dumb for the dummy... no
checking if we have EOVERFLOW macro... yes
checking for preferred network support... auto
checking for automatic network support... exec
checking IPv6 use... enabled
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating libmpg123.pc
config.status: creating libout123.pc
config.status: creating libsyn123.pc
config.status: creating mpg123.spec
config.status: creating src/config.h
config.status: executing depfiles commands
config.status: executing libtool commands

  mpg123 1.32.4

  Install path ............ /usr/local
  Components .............. libmpg123
  CPU Optimization ........ generic_float
  Compiler Optimization ... 2
  Use yasm (for AVX only) . disabled
  Gapless Support ......... enabled
  Debugging ............... disabled
  Terminal control ........ posix
  Extreme debugging ....... disabled
  Seek table size ......... 1000
  FIFO support ............ enabled
  Buffer .................. enabled
  External network ........ exec
  Internal network type ... posix
  IPv6 (getaddrinfo) ...... enabled
  largefile sensitive ..... no
  default offsets ......... 64
  explicit 64 bit offsets . no
  only portable API ....... yes

  Core libmpg123 features:
  Layer I ................. disabled
  Layer II ................ disabled
  Layer III ............... enabled
  NtoM resampling ......... enabled
  downsampled decoding .... enabled
  Feeder/buffered input ... enabled
  ID3v2 parsing ........... disabled
  String API .............. disabled
  ICY parsing/conversion .. disabled
  Error/warning messages .. enabled
  Win32 Unicode File Open.. unneeded
  Feature Report Function.. enabled
  Output formats (nofpu will disable all but 16 or 8 bit!):
  8 bit integer ........... enabled
  16 bit integer .......... enabled
  32/24 bit integer ....... disabled
  real (32 bit float) ..... enabled
  Equalizer ............... disabled
  Optimization detail:
  Integer conversion ...... quality
  IEEE 754 hackery ........ enabled
  New/old WRITE_SAMPLE .... disabled
  new Huffman scheme ...... enabled
  runtime tables .......... disabled

Note: Disabling core features is not commonly done and some combinations might
      not build/work. If you encounter such a case, help yourself (and provide
      a patch) or just poke the maintainers.

  libsyn123 special cases . enabled

  Modules ................. disabled
  Checked audio modules ... dummy
  Detected audio support .. dummy
  Runtime order ........... dummy

The _single_ active output module dummy is being statically linked in.

  CPPFLAGS=' -DOPT_GENERIC -DREAL_IS_FLOAT '
  CFLAGS='-O2 -fomit-frame-pointer -funroll-all-loops -finline-functions -ffast-math  -g -O2'
  PROG_LIBS='-lm '
       (derived from LIBS, only used for end-user binaries and modules)
  LIBDL=''
  LIBMPG123_LIBS='-lm '
  LIBSYN123_LIBS='-lm'
  LIBOUT123_LIBS=' -lm '

Next type 'make' and then 'make install'.
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I./src  -DPKGLIBDIR="\"/usr/local/lib/mpg123\""  -I./src/include -DOPT_GENERIC -DREAL_IS_FLOAT   -O2 -fomit-frame-pointer -funroll-all-loops -finline-functions -ffast-math  -g -O2 -MT src/libmpg123/libmpg123_la-parse.lo -MD -MP -MF src/libmpg123/.deps/libmpg123_la-parse.Tpo -c -o src/libmpg123/libmpg123_la-parse.lo `test -f 'src/libmpg123/parse.c' || echo './'`src/libmpg123/parse.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I./src -DPKGLIBDIR=\"/usr/local/lib/mpg123\" -I./src/include -DOPT_GENERIC -DREAL_IS_FLOAT -O2 -fomit-frame-pointer -funroll-all-loops -finline-functions -ffast-math -g -O2 -MT src/libmpg123/libmpg123_la-parse.lo -MD -MP -MF src/libmpg123/.deps/libmpg123_la-parse.Tpo -c src/libmpg123/parse.c -o src/libmpg123/libmpg123_la-parse.o
mv -f src/libmpg123/.deps/libmpg123_la-parse.Tpo src/libmpg123/.deps/libmpg123_la-parse.Plo
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I./src  -DPKGLIBDIR="\"/usr/local/lib/mpg123\""  -I./src/include -DOPT_GENERIC -DREAL_IS_FLOAT   -O2 -fomit-frame-pointer -funroll-all-loops -finline-functions -ffast-math  -g -O2 -MT src/libmpg123/libmpg123_la-frame.lo -MD -MP -MF src/libmpg123/.deps/libmpg123_la-frame.Tpo -c -o src/libmpg123/libmpg123_la-frame.lo `test -f 'src/libmpg123/frame.c' || echo './'`src/libmpg123/frame.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I./src -DPKGLIBDIR=\"/usr/local/lib/mpg123\" -I./src/include -DOPT_GENERIC -DREAL_IS_FLOAT -O2 -fomit-frame-pointer -funroll-all-loops -finline-functions -ffast-math -g -O2 -MT src/libmpg123/libmpg123_la-frame.lo -MD -MP -MF src/libmpg123/.deps/libmpg123_la-frame.Tpo -c src/libmpg123/frame.c -o src/libmpg123/libmpg123_la-frame.o
mv -f src/libmpg123/.deps/libmpg123_la-frame.Tpo src/libmpg123/.deps/libmpg123_la-frame.Plo
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I./src  -DPKGLIBDIR="\"/usr/local/lib/mpg123\""  -I./src/include -DOPT_GENERIC -DREAL_IS_FLOAT   -O2 -fomit-frame-pointer -funroll-all-loops -finline-functions -ffast-math  -g -O2 -MT src/libmpg123/libmpg123_la-format.lo -MD -MP -MF src/libmpg123/.deps/libmpg123_la-format.Tpo -c -o src/libmpg123/libmpg123_la-format.lo `test -f 'src/libmpg123/format.c' || echo './'`src/libmpg123/format.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I./src -DPKGLIBDIR=\"/usr/local/lib/mpg123\" -I./src/include -DOPT_GENERIC -DREAL_IS_FLOAT -O2 -fomit-frame-pointer -funroll-all-loops -finline-functions -ffast-math -g -O2 -MT src/libmpg123/libmpg123_la-format.lo -MD -MP -MF src/libmpg123/.deps/libmpg123_la-format.Tpo -c src/libmpg123/format.c -o src/libmpg123/libmpg123_la-format.o
mv -f src/libmpg123/.deps/libmpg123_la-format.Tpo src/libmpg123/.deps/libmpg123_la-format.Plo
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I./src  -DPKGLIBDIR="\"/usr/local/lib/mpg123\""  -I./src/include -DOPT_GENERIC -DREAL_IS_FLOAT   -O2 -fomit-frame-pointer -funroll-all-loops -finline-functions -ffast-math  -g -O2 -MT src/libmpg123/libmpg123_la-dct64.lo -MD -MP -MF src/libmpg123/.deps/libmpg123_la-dct64.Tpo -c -o src/libmpg123/libmpg123_la-dct64.lo `test -f 'src/libmpg123/dct64.c' || echo './'`src/libmpg123/dct64.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I./src -DPKGLIBDIR=\"/usr/local/lib/mpg123\" -I./src/include -DOPT_GENERIC -DREAL_IS_FLOAT -O2 -fomit-frame-pointer -funroll-all-loops -finline-functions -ffast-math -g -O2 -MT src/libmpg123/libmpg123_la-dct64.lo -MD -MP -MF src/libmpg123/.deps/libmpg123_la-dct64.Tpo -c src/libmpg123/dct64.c -o src/libmpg123/libmpg123_la-dct64.o
mv -f src/libmpg123/.deps/libmpg123_la-dct64.Tpo src/libmpg123/.deps/libmpg123_la-dct64.Plo
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I./src  -DPKGLIBDIR="\"/usr/local/lib/mpg123\""  -I./src/include -DOPT_GENERIC -DREAL_IS_FLOAT   -O2 -fomit-frame-pointer -funroll-all-loops -finline-functions -ffast-math  -g -O2 -MT src/libmpg123/libmpg123_la-id3.lo -MD -MP -MF src/libmpg123/.deps/libmpg123_la-id3.Tpo -c -o src/libmpg123/libmpg123_la-id3.lo `test -f 'src/libmpg123/id3.c' || echo './'`src/libmpg123/id3.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I./src -DPKGLIBDIR=\"/usr/local/lib/mpg123\" -I./src/include -DOPT_GENERIC -DREAL_IS_FLOAT -O2 -fomit-frame-pointer -funroll-all-loops -finline-functions -ffast-math -g -O2 -MT src/libmpg123/libmpg123_la-id3.lo -MD -MP -MF src/libmpg123/.deps/libmpg123_la-id3.Tpo -c src/libmpg123/id3.c -o src/libmpg123/libmpg123_la-id3.o
mv -f src/libmpg123/.deps/libmpg123_la-id3.Tpo src/libmpg123/.deps/libmpg123_la-id3.Plo
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I./src  -DPKGLIBDIR="\"/usr/local/lib/mpg123\""  -I./src/include -DOPT_GENERIC -DREAL_IS_FLOAT   -O2 -fomit-frame-pointer -funroll-all-loops -finline-functions -ffast-math  -g -O2 -MT src/libmpg123/libmpg123_la-optimize.lo -MD -MP -MF src/libmpg123/.deps/libmpg123_la-optimize.Tpo -c -o src/libmpg123/libmpg123_la-optimize.lo `test -f 'src/libmpg123/optimize.c' || echo './'`src/libmpg123/optimize.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I./src -DPKGLIBDIR=\"/usr/local/lib/mpg123\" -I./src/include -DOPT_GENERIC -DREAL_IS_FLOAT -O2 -fomit-frame-pointer -funroll-all-loops -finline-functions -ffast-math -g -O2 -MT src/libmpg123/libmpg123_la-optimize.lo -MD -MP -MF src/libmpg123/.deps/libmpg123_la-optimize.Tpo -c src/libmpg123/optimize.c -o src/libmpg123/libmpg123_la-optimize.o
mv -f src/libmpg123/.deps/libmpg123_la-optimize.Tpo src/libmpg123/.deps/libmpg123_la-optimize.Plo
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I./src  -DPKGLIBDIR="\"/usr/local/lib/mpg123\""  -I./src/include -DOPT_GENERIC -DREAL_IS_FLOAT   -O2 -fomit-frame-pointer -funroll-all-loops -finline-functions -ffast-math  -g -O2 -MT src/libmpg123/libmpg123_la-readers.lo -MD -MP -MF src/libmpg123/.deps/libmpg123_la-readers.Tpo -c -o src/libmpg123/libmpg123_la-readers.lo `test -f 'src/libmpg123/readers.c' || echo './'`src/libmpg123/readers.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I./src -DPKGLIBDIR=\"/usr/local/lib/mpg123\" -I./src/include -DOPT_GENERIC -DREAL_IS_FLOAT -O2 -fomit-frame-pointer -funroll-all-loops -finline-functions -ffast-math -g -O2 -MT src/libmpg123/libmpg123_la-readers.lo -MD -MP -MF src/libmpg123/.deps/libmpg123_la-readers.Tpo -c src/libmpg123/readers.c -o src/libmpg123/libmpg123_la-readers.o
mv -f src/libmpg123/.deps/libmpg123_la-readers.Tpo src/libmpg123/.deps/libmpg123_la-readers.Plo
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I./src  -DPKGLIBDIR="\"/usr/local/lib/mpg123\""  -I./src/include -DOPT_GENERIC -DREAL_IS_FLOAT   -O2 -fomit-frame-pointer -funroll-all-loops -finline-functions -ffast-math  -g -O2 -MT src/libmpg123/libmpg123_la-tabinit.lo -MD -MP -MF src/libmpg123/.deps/libmpg123_la-tabinit.Tpo -c -o src/libmpg123/libmpg123_la-tabinit.lo `test -f 'src/libmpg123/tabinit.c' || echo './'`src/libmpg123/tabinit.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I./src -DPKGLIBDIR=\"/usr/local/lib/mpg123\" -I./src/include -DOPT_GENERIC -DREAL_IS_FLOAT -O2 -fomit-frame-pointer -funroll-all-loops -finline-functions -ffast-math -g -O2 -MT src/libmpg123/libmpg123_la-tabinit.lo -MD -MP -MF src/libmpg123/.deps/libmpg123_la-tabinit.Tpo -c src/libmpg123/tabinit.c -o src/libmpg123/libmpg123_la-tabinit.o
mv -f src/libmpg123/.deps/libmpg123_la-tabinit.Tpo src/libmpg123/.deps/libmpg123_la-tabinit.Plo
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I./src  -DPKGLIBDIR="\"/usr/local/lib/mpg123\""  -I./src/include -DOPT_GENERIC -DREAL_IS_FLOAT   -O2 -fomit-frame-pointer -funroll-all-loops -finline-functions -ffast-math  -g -O2 -MT src/libmpg123/libmpg123_la-libmpg123.lo -MD -MP -MF src/libmpg123/.deps/libmpg123_la-libmpg123.Tpo -c -o src/libmpg123/libmpg123_la-libmpg123.lo `test -f 'src/libmpg123/libmpg123.c' || echo './'`src/libmpg123/libmpg123.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I./src -DPKGLIBDIR=\"/usr/local/lib/mpg123\" -I./src/include -DOPT_GENERIC -DREAL_IS_FLOAT -O2 -fomit-frame-pointer -funroll-all-loops -finline-functions -ffast-math -g -O2 -MT src/libmpg123/libmpg123_la-libmpg123.lo -MD -MP -MF src/libmpg123/.deps/libmpg123_la-libmpg123.Tpo -c src/libmpg123/libmpg123.c -o src/libmpg123/libmpg123_la-libmpg123.o
src/libmpg123/libmpg123.c: In function ‘mpg123_open_handle’:
src/libmpg123/libmpg123.c:653:60: error: ‘LFS_WRAP_NONE’ undeclared (first use in this function)
  653 |                 ret = INT123_open_stream_handle(mh, ret == LFS_WRAP_NONE ? iohandle : mh->wrapperdata);
      |                                                            ^~~~~~~~~~~~~
src/libmpg123/libmpg123.c:653:60: note: each undeclared identifier is reported only once for each function it appears in
make: *** [Makefile:4346: src/libmpg123/libmpg123_la-libmpg123.lo] Error 1
vampi:~/Code/ttsclient/mpg123-1.32.4$ 

It looks to me like this code is the issue in libmpg123.c:

#ifndef PORTABLE_API
#include "lfs_wrap.h"
#endif

...

#ifndef PORTABLE_API
    ret = INT123_wrap_open( mh, iohandle, NULL, -1
    ,   mh->p.timeout, mh->p.flags & MPG123_QUIET );
    if(ret >= 0)
#endif
        ret = INT123_open_stream_handle(mh, ret == LFS_WRAP_NONE ? iohandle : mh->wrapperdata);
    return ret;

So in other words, LFS_WRAP_NONE is only defined when NOT in portable mode, and I'm in portable mode. Not sure what the fix is in this case.

[Thomas Orgis]

Yeah, that was stupid of me. Please check current trunk or
https://mpg123.org/snapshot . I should release 1.32.5 shortly.