#177 crash on get_module_dir()

0.68
closed-fixed
nobody
mpg123 (103)
5
2013-02-24
2012-09-09
No

Under some circumstances closedir() will be called with dir being NULL. The attached diff fixes it.

Discussion

  • Thomas Orgis

    Thomas Orgis - 2012-09-09

    Could you give more details on which configuration this crashes? My GNU/Linux system is happy with a verbatim closedir(NULL).

    I'm not generally opposing avoiding the unnecessary call, but I'd like to know what systems are actually affected.

     
  • Federico Schwindt

    OpenBSD but I could reproduce it on FreeBSD as well.

     
  • Thomas Orgis

    Thomas Orgis - 2012-09-10

    Ah, BSD it is. Does current trunk (or snapshot being prepared right now) work?

     
  • Thomas Orgis

    Thomas Orgis - 2013-02-24
    • status: open --> closed-fixed
    • milestone: --> 0.68
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks