#115 mpg123_scan counts partial frames at the end of mp3 files

0.68
closed
nobody
None
5
5 days ago
2009-09-22
Patr3ck
No

I just have to assume we're past this.

Discussion

  • Patr3ck

    Patr3ck - 2009-09-23

    mpg123_read seems to also decode the last partial frame. What is the behavior wanted from libmpg123, try to decode the partial frame and fill up with zeroes? Then feeder mode would be incorrect in frame count and decoded samples. Or is it OK that they behave differently?

     
  • Thomas Orgis

    Thomas Orgis - 2009-09-23

    Eh... please define "partial frame". The parser reads it fine, so it's counted by scan?

     
  • Patr3ck

    Patr3ck - 2009-09-23

    partial frame. a frame header is there but the frame body is incomplete.

    Thomas said on IRC:
    [14:41] <sobukus> a partial frame should not make get_next_frame() succeed
    [14:41] <sobukus> so it should not be counted

     
  • Thomas Orgis

    Thomas Orgis - 2012-03-07

    Is there a current info on this issue?

     
  • Thomas Orgis

    Thomas Orgis - 5 days ago
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1 +1 @@
    -the frame count is wrong and return from mpg123\_length also is incorrect
    +I just have to assume we're past this.
    
    • status: open --> closed
    • Group: --> 0.68
     
  • Thomas Orgis

    Thomas Orgis - 5 days ago

    I just have to assume wer're past this.

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks