Menu

#6 typo in configure option for duplex printing

open
nobody
None
5
2008-11-26
2008-11-26
Klaus Heinz
No

Hi,

in version 3.7.1 the file configure.in contains

AC_ARG_ENABLE(duplex,
[ --disable-duplex disable duplex printing
[default=yes]], ,
enable_duplex="yes")

If you look carefully at this autoconf snippet you
will see that this actually _enables_ duplex printing.

To correct this you can replace "disable" by "enable".
This keeps the current behaviour to have duplex
enabled by default, see the appended patch.

The trailing ":" in the patch prevents the configure
script from exiting with an error when duplex printing
is turned _off_.
This error occurs due to the trap function for signal
0 which uses the return code of the last command

test x"$enable_duplex" = xyes && ...

as the exit code for the whole configure script.

ciao
Klaus

Discussion

  • Klaus Heinz

    Klaus Heinz - 2008-11-26

    Of course I found the entry in the ChangeLog concerning
    the incorrectly reversed duplex setting _after_ I submitted
    the patch...

    The new version leaves the "--disable-duplex" syntax
    and just changes the description.
    File Added: patch-af

     
  • Klaus Heinz

    Klaus Heinz - 2008-11-26

    Correct description of duplex option

     

Log in to post a comment.

MongoDB Logo MongoDB