Menu ▾ ▴

#3 ClassGenerator: misc fixes

1.0
open
nobody
None
2014-03-20
2014-03-04
Andrea Laforgia
No

Cpp classes:
1) fix cpp generation so that the size_type is used

Java classes:
1) add packages clauses (model, requests, responses) [DONE]
3) add "import lib.;" [DONE]
4) add "throws IOException" to readFromSocket / writeToSocket methods [DONE]
5) generate directly usage of DataInputStream/DataOutputStream instead of NetworkDataStreamer [DONE]
6) fix imports for requests/responses [DONE]
7) transform [i] to .get(i) for Java lists [DONE]
8) move classes that shouldn't be deleted to lib/
9) create script to delete generated Java classes

10) fix indentation in generated classes (low priority)
11) don't generate readFromStream for C++ requests
12) don't generate writeFromStream for Java responses

13) generate code for request processors
14) generate code for request factory and request processor factory
15) request id should be a constant in the request
16) strings should have a 1-byte length - cut string when sending
17) requests should be generated even when there's no input parameters in the request definition

Discussion

  • Andrea Laforgia

    Andrea Laforgia - 2014-03-04
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,20 +1,20 @@

 bug fixes:
-fix generation of vector of byte
+fix generation of vector of byte [DONE]

 1) inclusion of #include "stdafx.h" in all cpp files
 not to header files

 2) add inheritance from AbstractRequest / AbstractResponse

-3) deduct includes for headers/cpp files
+3) deduct includes for headers/cpp files - determine what are the fixed

-4) add override of setErrorCode / setErrorMessage in responses
+4) add override of setErrorCode / setErrorMessage in responses [CHECK THIS]

 5) os << indentationSpaces << "object anObjectArray[" << anObjectArray.size() << "] (" << std::endl

-   Add ; at the end
+   Add ; at the end [DONE]

-6) indentationSpaces sometimes called indentationSpace
+6) indentationSpaces sometimes called indentationSpace [DONE]

 7) include "Streamable.h" for model classes

@@ -22,6 +22,8 @@

 9) include streaming of errorCode / errorMessage

-10) add generation of constructor for requets:     RegisterPlayerRequest(unsigned int id): AbstractRequest(id) {}
+10) add generation of constructor for requests:    RegisterPlayerRequest(unsigned int id): AbstractRequest(id) {}
+[DONE]


-  
+
+
     

  • Andrea Laforgia

    Andrea Laforgia - 2014-03-04
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,29 +1,19 @@
+bug fixes:

-bug fixes:
-fix generation of vector of byte [DONE]
+0) fix generation of vector of byte [DONE]
+2) add inheritance from AbstractRequest / AbstractResponse [DONE]
+6) indentationSpaces sometimes called indentationSpace [DONE]
+10) add generation of constructor for requests - [DONE]
+5) << std::endl - Add ; at the end [DONE]

-1) inclusion of #include "stdafx.h" in all cpp files
-not to header files
-
-2) add inheritance from AbstractRequest / AbstractResponse
-
+1) inclusion of #include "stdafx.h" in all cpp files - not to header files
 3) deduct includes for headers/cpp files - determine what are the fixed
-
 4) add override of setErrorCode / setErrorMessage in responses [CHECK THIS]
-
-5) os << indentationSpaces << "object anObjectArray[" << anObjectArray.size() << "] (" << std::endl

-   Add ; at the end [DONE]
-   
-6) indentationSpaces sometimes called indentationSpace [DONE]
-
 7) include "Streamable.h" for model classes
-
 8) add call to superclass' print() in response (to include errorCode / errorMessage)
-
 9) include streaming of errorCode / errorMessage

-10) add generation of constructor for requests:    RegisterPlayerRequest(unsigned int id): AbstractRequest(id) {}
-[DONE]
+
     

  • Andrea Laforgia

    Andrea Laforgia - 2014-03-04
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -5,13 +5,11 @@
 6) indentationSpaces sometimes called indentationSpace [DONE]
 10) add generation of constructor for requests - [DONE]
 5) << std::endl - Add ; at the end [DONE]
-
-1) inclusion of #include "stdafx.h" in all cpp files - not to header files
-3) deduct includes for headers/cpp files - determine what are the fixed
-4) add override of setErrorCode / setErrorMessage in responses [CHECK THIS]
-7) include "Streamable.h" for model classes
-8) add call to superclass' print() in response (to include errorCode / errorMessage)
-9) include streaming of errorCode / errorMessage
+1) inclusion of #include "stdafx.h" in all cpp files - not to header files [DONE]
+3) deduct includes for headers/cpp files - determine what are the fixed [DONE]
+7) include "Streamable.h" for model classes [DONE]
+8) add call to superclass' print() in response (to include errorCode / errorMessage) [DONE]
+9) include streaming of errorCode / errorMessage [DONE]
     

  • Andrea Laforgia

    Andrea Laforgia - 2014-03-05
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,17 +1,12 @@
-bug fixes:
+Cpp classes:
+1) fix cpp generation so that the size_type is used

-0) fix generation of vector of byte [DONE]
-2) add inheritance from AbstractRequest / AbstractResponse [DONE]
-6) indentationSpaces sometimes called indentationSpace [DONE]
-10) add generation of constructor for requests - [DONE]
-5) << std::endl - Add ; at the end [DONE]
-1) inclusion of #include "stdafx.h" in all cpp files - not to header files [DONE]
-3) deduct includes for headers/cpp files - determine what are the fixed [DONE]
-7) include "Streamable.h" for model classes [DONE]
-8) add call to superclass' print() in response (to include errorCode / errorMessage) [DONE]
-9) include streaming of errorCode / errorMessage [DONE]
-
-
-
-

-   
+Java classes:
+1) add packages clauses (model, requests, responses) [DONE]
+3) add "import lib.*;" [DONE]
+4) add "throws IOException" to readFromSocket / writeToSocket methods [DONE]
+5) generate directly usage of DataInputStream/DataOutputStream instead of NetworkDataStreamer [DONE]
+6) fix imports for requests/responses [DONE]
+7) transform [i] to .get(i) for Java lists [DONE]
+8) move classes that shouldn't be deleted to lib/*
+9) create script to delete generated Java classes
     

  • Andrea Laforgia

    Andrea Laforgia - 2014-03-06
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -10,3 +10,7 @@
 7) transform [i] to .get(i) for Java lists [DONE]
 8) move classes that shouldn't be deleted to lib/*
 9) create script to delete generated Java classes 
+
+10) fix indentation in generated classes (low priority)
+11) don't generate readFromStream for C++ requests
+12) don't generate writeFromStream for Java responses
     

  • Andrea Laforgia

    Andrea Laforgia - 2014-03-17
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -14,3 +14,8 @@
 10) fix indentation in generated classes (low priority)
 11) don't generate readFromStream for C++ requests
 12) don't generate writeFromStream for Java responses
+
+13) generate code for request processors
+14) generate code for request factory and request processor factory
+15) request id should be a constant in the request
+16) strings should have a 1-byte length - cut string when sending
     

  • Andrea Laforgia

    Andrea Laforgia - 2014-03-20
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -19,3 +19,4 @@
 14) generate code for request factory and request processor factory
 15) request id should be a constant in the request
 16) strings should have a 1-byte length - cut string when sending
+17) requests should be generated even when there's no input parameters in the request definition
     

Log in to post a comment.

MongoDB Logo MongoDB