#13 Higher ID3v1.1 Genre tags get replaced with 126 (Goa)

closed-accepted
ID3 V1 Tag (5)
5
2005-02-20
2005-01-17
No

Higher ID3v1.1 Genre tags get replaced with 126 (Goa)

Reading and writing a tag with a genre value of 255
(used by many apps for 'no genre' or any genre indicies
in the 126-147 range (I'm unsure where the extension
came from) get mapped to 126 which is read by many apps
as goa. I've done some simple fixes which I'll
attach... Useful for the genre list if nothing else...

Discussion

  • Peter Bradshaw

    Peter Bradshaw - 2005-01-17

    Logged In: YES
    user_id=407246

    diff output:

    $ diff ID3Tag.original ID3Tag.java
    64c64,70
    < "Drum Solo","Acapella","Euro-House","Dance Hall",
    "unknown"};
    ---
    > "Drum Solo","Acapella","Euro-House","Dance Hall",
    > "Goa", "Drum & Bass",
    > "Club-House", "Hardcore", "Terror", "Indie",
    "BritPop", "Negerpunk",
    > "Polsk Punk", "Beat", "Christian Gangsta Rap",
    "Heavy Metal",
    > "Black Metal", "Crossover", "Contemporary
    Christian", "Christian Rock",
    > "Merengue", "Salsa", "Thrash Metal", "Anime",
    "Jpop", "Synthpop"
    > ,"unknown"};
    196c202,204
    < public String getGenreS () { return genres[genre];}
    ---
    > public String getGenreS () {
    > if(genre >= genres.length){return
    genres[genres.length-1];}
    > return genres[genre];}
    198,202c206
    < public void setGenre (byte g) {
    < if (g>=0 && g<126) genre = g;
    < // Setting genre to "Unknown)
    < else genre = 126;
    < }
    ---
    > public void setGenre (byte g) { genre = g; }

     
  • Peter Bradshaw

    Peter Bradshaw - 2005-01-17

    source file with above changes and constructor change

     
  • Florian Heer

    Florian Heer - 2005-02-14
    • labels: --> ID3 V1 Tag
    • assigned_to: nobody --> heer
    • status: open --> open-later
     
  • Florian Heer

    Florian Heer - 2005-02-14

    Logged In: YES
    user_id=223730

    To be honest, I did so on purpose, but with no argument
    strong enough to keep it that way. At the time I wrote
    (took) the list, the genres were the most official ones I
    could find.

     
  • Florian Heer

    Florian Heer - 2005-02-20

    Logged In: YES
    user_id=223730

    Okay, your change is incorporated in the cvs. Thank you.

     
  • Florian Heer

    Florian Heer - 2005-02-20
    • status: open-later --> closed-accepted
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks