Eric RANNAUD - 2007-02-24

Hi,

(this build error has already been signaled on this forum, but not seems to have been addressed yet)

There is an inconsistency in src/main.cc which makes mp3blaster-3.2.3 not build with the --with-pth option (and no other), with the following error :

main.cc: In function ‘int main(int, char**, char**)’:
main.cc:5401: error: ‘struct main(int, char**, char**)::_tmp’ has no member named ‘threads’

The definition of the member threads is guarded by an #ifdef but not the subsequent use of that member.
Adding the #ifdef around the later lets mp3blaster build. And the resulting binary seems to work.

Cheers,
Eric.

--- mp3blaster-3.2.3/src/main.cc.orig   2006-08-05 23:11:11.000000000 +0200
+++ mp3blaster-3.2.3/src/main.cc        2007-02-24 16:35:01.000000000 +0100
@@ -5398,7 +5398,9 @@
        tmp.mixer_device = NULL;
        tmp.play_mode = NULL;
        tmp.fpl = 5;
+#ifdef PTHREADEDMPEG
        tmp.threads = 10;
+#endif

        environment = envp;