Anton Sharonov - 2009-03-17

Hi, Bram !

First of all, thanks for the nice software.

I have made several minor enhancements to the mp3blaster, so
please find 3 patches in the patches area (i have sent them to
your sourceforge e-mail address as well, don't know either it has
reaches you or not):

UTF8 chars (Russian) are displayed properly
/<CR> - jumps to the currently played song
/*<PATTERN> - special search in playlist

4th patch:

Changes caused by automake (autoconf?)

is probably don't necessary, but I mention it here just for
completeness. (if you need this 4th patch please tell me).

----------------------------------------------------------------
Subject: [PATCH 1/4] UTF8 chars (Russian) are displayed properly

to display them two things are necessary:

1) link against ncursesw instead of ncurses (i.e., the library
name must have trailing _w_ character)

2) setlocale() call before initscr()

Note, that changes in configure.ac requires one to re-run the
automake (autoconf ? I'm not very familiar with those)
---
configure.ac |    4 ++--
src/main.cc  |    4 ++++
2 files changed, 6 insertions(+), 2 deletions(-)

----------------------------------------------------------------
Subject: [PATCH 2/4] /<CR> - jumps to the currently played song

The problem

In case the playlist is big and playback is in "shuffle" mode, it
is relatively hard to quickly find the song, which is actually
played (for instance, to remove this song from playlist).

The solution

Added special handling of empty pattern to the "search the
playlist" feature. After search is started ('/' is pressed), user
should not enter any search pattern but just immediately press
<CR> (ENTER). This is interpreted as a command to jump to the
currently played song in the playlist window.
---
src/main.cc |   23 +++++++++++++++++++++++
1 files changed, 23 insertions(+), 0 deletions(-)

----------------------------------------------------------------
Subject: [PATCH 3/4] /*<PATTERN> - special search in playlist

Problem

Sometimes it is hard to locate the song, especially if playlist
is big, and user knows only part of the song's name. Lookup in
playlist matches currently starts from the first character, and
if there some leading trash (like "10 - Best Of Jazz..."), or one
isn't sure, what is going first - Artist or Song... You can
imagine how hard it can be to just locate such song in the list.

The solution

Added special handling of the search pattern, if it starts with
'*' character.

Description

After search in playlist is started ('/' is pressed), user should
not immediately enter her search pattern but precede it with '*'.
After the '*' remaining pattern (after leading '*' is removed)
does match everywhere in the string, without the anchor to the
begin of string. The patterns without leading '*' are continuing
to work as before.
---
src/main.cc |   15 ++++++++++++++-
1 files changed, 14 insertions(+), 1 deletions(-)

----------------------------------------------------------------
Subject: [PATCH 4/4] Changes caused by automake (autoconf?)

Those changes are not really neecessary to be sent as a patch,
but just in case that it is useful for somebody.
---
Makefile.in             |    1 +
aclocal.m4              |    4 +-
config.h.in             |   17 +-
configure               | 5154 ++++++++++++++++++++++++++---------------------
doc/Makefile.in         |    1 +
doc/charmap/Makefile.in |    1 +
mpegsound/Makefile.in   |    1 +
nmixer/Makefile.in      |    1 +
src/Makefile.in         |    1 +
9 files changed, 2871 insertions(+), 2310 deletions(-)

--
Best regards, Anton