Menu ▾ ▴

#52 SQL Error Message on Init when there are no Alerts

v1.0 (example)
closed-fixed
Mark Hummel
None
5
2018-12-26
2018-11-04
Mark Hummel
No

When there are no alerts, a SQL Error message appears.

Steps to replicate:
1. Use the database for quote sources;
2. Under preferences/Alerts, enable alerts.
3. Remove all alerts, if any.
4. Restart Venice
5. The message 'Error talking to database: You have an error in your SQL syntax..." should appear.

There are at least three issues here:
1. The code which checks for triggered alerts should check for an empty symbol list and then return instead of creating an EODQuoteRange without any symbols;
2. When given an EODQuoteRange that contains no symbols, DatabaseQuoteSource.loadQuoteRange builds a malformed SQL query;
3. DatabaseQuoteSource.loadQuoteRange should avoid sending superfluous queries to the database in the first place.

Discussion

  • Mark Hummel

    Mark Hummel - 2018-11-04
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,4 +1,11 @@
 When there are no alerts, a SQL Error message appears. 
+
+Steps to replicate:
+1. Use the  database for quote sources;
+2. Under preferences/Alerts, enable alerts.
+3. Remove all alerts, if any.
+4. Restart Venice
+5. The message 'Error talking to database: You have an error in your SQL syntax..." should appear.

 There are at least three issues  here:
 1. The code which checks for triggered alerts should check for an empty symbol list and then return instead of creating an  EODQuoteRange without any symbols;
     

  • Mark Hummel

    Mark Hummel - 2018-11-18
    • status: open --> pending-fixed
     

  • Mark Hummel

    Mark Hummel - 2018-12-26
    • status: pending-fixed --> closed-fixed
     

Log in to post a comment.