#10 mmaker fails due to broken proxy patch

closed-accepted
nobody
None
5
2005-04-21
2005-04-14
No

Recent proxy support commit broke mmaker. The reason is
that the value in module->proxy remains uninitialised
when not using proxies (it is compared with NULL later
to determine wether we have proxies or not).

This patch initialises it to NULL when proxy has this
value.

--- mmaker/src/main.c~ 2005-03-30 15:43:04.000000000 +0200
+++ mmaker/src/main.c 2005-04-14 16:34:40.000000000 +0200
@@ -150,9 +150,7 @@
if (interactive == TRUE) {
module->interactive = TRUE;
}
- if (proxy != NULL){
- module->proxy = proxy;
- }
+ module->proxy = proxy;
setTempDir(module,tempdir);
if
(!makeModuleToFile(module,argv[1+opts],argv[2+opts],leave_dir,debtarball,debbzip2,debootdir))
{
fprintf(stderr,"Error: Building
of module failed!\n");

Discussion

  • Jure Cuhalev

    Jure Cuhalev - 2005-04-17

    Logged In: YES
    user_id=675570

    commited, please close

     
  • Alex de Landgraaf

    • status: open --> closed-accepted
     
  • Alex de Landgraaf

    Logged In: YES
    user_id=97489

    morphix-mmaker-0.4-17 has been uploaded, includes fix, closing

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks