Re: [Morphix-devel] Unforeseen Opportunity for Improvement in morphixinstaller?

[Alex de L. <al...@de...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

You're completely correct, it's back to C programming 101 for me.

Thanks for the fix. I'll commit the changes and upload a new MI package
shortly.

There has been some development on a MI-replacement in python, but it's
not production-quality yet. Then again, looking at the original MI code
from 3 years ago, the term 'production-quality' is rather flexible.

Thanks again,

Alex

Mark Gannon wrote:
> Hello,
> 
> I've been experiencing a segmentation fault when I try and run 
> morphixinstaller on my system.  After carefully examining the code, the 
> segmentation fault appeared to occur in the BuildRoot function of instlib.c 
> where the code is examining the existing fstab file.  I was able to confirm 
> that was the section with the problem by deleting the existing /etc/fstab on 
> my system.  With no /etc/fstab, the code skips the section and doesn't 
> trigger the segmentation fault.
> 
> While I'm far from a competent C programmer, I did notice that the int used as 
> a loop counter (gint j) is not initialized in the code.  When I changed the 
> line 517 of instlib.c from:
> 
> gint i, j;
> 
> to:
> 
> gint i = 0;
> gint j = 0;
> 
> the problem went away.
> 
> I know I saw at least one other user on the forums with this issue.  Are there 
> any reasons we shouldn't make this change?
> 
> Regards,
> 
> Mark Gannon
> 
> 
> 
> ------------------------------------------------------------------------
> 
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Morphix-devel mailing list
> Mor...@li...
> https://lists.sourceforge.net/lists/listinfo/morphix-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFeUsUQeuQA5TF/UsRArYjAJwNgqsG+zVzs0pf/Id5KXG5JM0DTQCeI6cQ
x3rtyogOJ6aXKAM25sX1etY=
=G/LJ
-----END PGP SIGNATURE-----