Re: [morph-developer] getting involved
Brought to you by:
orangeherbert,
sgarlatm
From: Matt S. <Mat...@wh...> - 2006-12-19 23:38:14
|
Hello again Matt, sorry I'm still being slow with my responses, but I'm still trying to catch up from my week away from work :) In response to a previous email, you're right the ChainedConverter can't just fall back on the implementation of isTransformable in BaseTransformer but it does so anyway. So that is definitely broken. I probably haven't caught that in real life because I haven't actually used the ChainedConverter to do anything, it was more just trying out an idea to see if I could get it to work. Here are responses to your most recent email, inline: > MorphTestCase.testCopyToDestWithoutGetter() is not > even in CVS, though it's in the 1.0.1 release; in any > event, it probably bears some discussion as to what > would be correct behavior here. > I haven't been able to connect to CVS for some time, and I again was not able to connect today. So the code in CVS is fairly old. I sent you the latest Morph distribution. I haven't been cutting new releases because, as I mentioned, it takes me a good 2-3 hours to do a release. The problem is there are nearly a half dozen programs I have to use (ant to prepare the release, ftp to upload the release, secure ftp to upload the website to the web server, secure telnet to unzip the new version of the website and make sure I put it in the right directory) In addition to this being a huge pain in the neck, I also don't even have most of these programs on my computer anymore because I have a new laptop. Since I only use most of these programs every few months it means I have to relearn how to use them each time. My boss is on vacation right now, but I'll see if maybe we can setup my company's SVN repository so that it hosts Morph. That way I'll be able to connect to it, and hopefully we can get you access as well. Perhaps I can get web space for Morph as well, because although it does see a good bit of traffic, it shouldn't be anything too crippling. > The other two failures appear to be time-zone related > as I am in CST and these are expecting something with > EST. I will have a look at these, but FYI they are > > DefaultToTextConverterTestCase.testValidPairs() > TimeToTextConverterTestCase.testValidPairs() > I changed my timezone to Pacific time and received the same error you describe. I'm retrieving the default time format using this call: DateFormat.getDateTimeInstance(DateFormat.LONG, DateFormat.LONG); I think the bug is in the test case, not in the converters. I've explicitly hardcoded EST into the String for the test in BaseToTextConverterTestCase line 112: String converted = "January 30, 2005 11:51:02 AM EST"; Matt |