Re: [Monitorix-general] Reports no longer working

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

Hi,

Yes, your patch works!

I sent a report at 09:40 local time, and it looks like this.

Sun Jan 30 09:40:01 2022 - OK - [127.0.0.1] "GET /monitorix-cgi/monitorix.cgi - libwww-perl/6.52"
Sun Jan 30 09:40:01 2022 - OK - [127.0.0.1] "GET /monitorix/imgs/system1.1day.png - libwww-perl/6.52"
Sun Jan 30 09:40:01 2022 - OK - [127.0.0.1] "GET /monitorix/imgs/system2.1day.png - libwww-perl/6.52"
Sun Jan 30 09:40:01 2022 - OK - [127.0.0.1] "GET /monitorix/imgs/system3.1day.png - libwww-perl/6.52"
Sun Jan 30 09:40:01 2022 - OK - [127.0.0.1] "GET /monitorix/imgs/system4.1day.png - libwww-perl/6.52"
Sun Jan 30 09:40:01 2022 - OK - [127.0.0.1] "GET /monitorix/imgs/system5.1day.png - libwww-perl/6.52"
Sun Jan 30 09:40:01 2022 - OK - [127.0.0.1] "GET /monitorix-cgi/monitorix.cgi - libwww-perl/6.52"
Sun Jan 30 09:40:01 2022 - OK - [127.0.0.1] "GET /monitorix/imgs/fs01.1day.png - libwww-perl/6.52"
Sun Jan 30 09:40:01 2022 - OK - [127.0.0.1] "GET /monitorix/imgs/fs02.1day.png - libwww-perl/6.52"
Sun Jan 30 09:40:01 2022 - OK - [127.0.0.1] "GET /monitorix/imgs/fs03.1day.png - libwww-perl/6.52"
Sun Jan 30 09:40:01 2022 - OK - [127.0.0.1] "GET /monitorix/imgs/fs04.1day.png - libwww-perl/6.52"
Sun Jan 30 09:40:01 2022 - OK - [127.0.0.1] "GET /monitorix-cgi/monitorix.cgi - libwww-perl/6.52"
Sun Jan 30 09:40:01 2022 - OK - [127.0.0.1] "GET /monitorix/imgs/du0.1day.png - libwww-perl/6.52"
Sun Jan 30 09:40:01 2022 - OK - [127.0.0.1] "GET /monitorix/imgs/du1.1day.png - libwww-perl/6.52"
Sun Jan 30 09:40:02 2022 - OK - [127.0.0.1] "GET /monitorix-cgi/monitorix.cgi - libwww-perl/6.52"
Sun Jan 30 09:40:02 2022 - OK - [127.0.0.1] "GET /monitorix/imgs/port0i.1day.png - libwww-perl/6.52"
Sun Jan 30 09:40:02 2022 - OK - [127.0.0.1] "GET /monitorix/imgs/port1i.1day.png - libwww-perl/6.52"
Sun Jan 30 09:40:02 2022 - OK - [127.0.0.1] "GET /monitorix/imgs/port2i.1day.png - libwww-perl/6.52"
Sun Jan 30 09:40:02 2022 - OK - [127.0.0.1] "GET /monitorix/imgs/port3i.1day.png - libwww-perl/6.52"
Sun Jan 30 09:40:02 2022 - OK - [127.0.0.1] "GET /monitorix/imgs/port4i.1day.png - libwww-perl/6.52"
Sun Jan 30 09:40:02 2022 - OK - [127.0.0.1] "GET /monitorix/imgs/port5i.1day.png - libwww-perl/6.52"

Thank you for your help.

Regards

/Michael

-----Original message-----
From: Jordi Sanfeliu via Monitorix-general <mon...@li...>
Sent: Sunday 30th January 2022 8:07
To: Micke Test via Monitorix-general <mon...@li...>
Cc: Jordi Sanfeliu <jo...@fi...>
Subject: Re: [Monitorix-general] Reports no longer working

Hi,

Good news!, I finally was able to reproduce this and indeed there is a bug.

This is the log with the current version:

Sun Jan 30 07:49:00 2022 - OK - [127.0.0.1] "GET 
/monitorix-cgi/monitorix.cgi - libwww-perl/6.60"
Sun Jan 30 07:49:00 2022 - NOTEXIST - [127.0.0.1] File does not exist: /

Sun Jan 30 07:49:00 2022 - NOTEXIST - [127.0.0.1] File does not exist: /

Sun Jan 30 07:49:00 2022 - NOTEXIST - [127.0.0.1] File does not exist: /

Sun Jan 30 07:49:00 2022 - NOTEXIST - [127.0.0.1] File does not exist: /

Sun Jan 30 07:49:00 2022 - NOTEXIST - [127.0.0.1] File does not exist: /

Sun Jan 30 07:49:01 2022 - OK - [127.0.0.1] "GET 
/monitorix-cgi/monitorix.cgi - libwww-perl/6.60"
Sun Jan 30 07:49:01 2022 - NOTEXIST - [127.0.0.1] File does not exist: /

Sun Jan 30 07:49:01 2022 - NOTEXIST - [127.0.0.1] File does not exist: /

Sun Jan 30 07:49:01 2022 - NOTEXIST - [127.0.0.1] File does not exist: /

Sun Jan 30 07:49:01 2022 - NOTEXIST - [127.0.0.1] File does not exist: /

Sun Jan 30 07:49:01 2022 - OK - [127.0.0.1] "GET /monitorix - 
libwww-perl/6.60"

and this is the log once patched:

Sun Jan 30 07:55:01 2022 - OK - [127.0.0.1] "GET 
/monitorix-cgi/monitorix.cgi - libwww-perl/6.60"
Sun Jan 30 07:55:01 2022 - OK - [127.0.0.1] "GET 
/monitorix/imgs/system1.1day.png - libwww-perl/6.60"
Sun Jan 30 07:55:01 2022 - OK - [127.0.0.1] "GET 
/monitorix/imgs/system2.1day.png - libwww-perl/6.60"
Sun Jan 30 07:55:01 2022 - OK - [127.0.0.1] "GET 
/monitorix/imgs/system3.1day.png - libwww-perl/6.60"
Sun Jan 30 07:55:01 2022 - OK - [127.0.0.1] "GET 
/monitorix/imgs/system4.1day.png - libwww-perl/6.60"
Sun Jan 30 07:55:01 2022 - OK - [127.0.0.1] "GET 
/monitorix/imgs/system5.1day.png - libwww-perl/6.60"
Sun Jan 30 07:55:01 2022 - OK - [127.0.0.1] "GET 
/monitorix-cgi/monitorix.cgi - libwww-perl/6.60"
Sun Jan 30 07:55:01 2022 - OK - [127.0.0.1] "GET 
/monitorix/imgs/fs01.1day.png - libwww-perl/6.60"
Sun Jan 30 07:55:01 2022 - OK - [127.0.0.1] "GET 
/monitorix/imgs/fs02.1day.png - libwww-perl/6.60"
Sun Jan 30 07:55:01 2022 - OK - [127.0.0.1] "GET 
/monitorix/imgs/fs03.1day.png - libwww-perl/6.60"
Sun Jan 30 07:55:01 2022 - OK - [127.0.0.1] "GET 
/monitorix/imgs/fs04.1day.png - libwww-perl/6.60"
Sun Jan 30 07:55:01 2022 - OK - [127.0.0.1] "GET /monitorix - 
libwww-perl/6.60"

The problem is in line 138 of the 'emailreports.pm' module. During the 
parsing of the HTML, the current code is trying find the URLs of the 
images enclosed with single quotes, but they are now enclosed with 
double quotes.

The line 138 should be changed by the following code:

($url) = $_ =˜ m/<img src=['"](.*?)['"] /;

which covers both single or double quotes.

Michael, please, patch manually your file in 
/usr/lib/monitorix/emailreports.pm, then restart Monitorix and let us 

know if that really fixed it.

Thanks.

On 1/29/22 22:21, Micke Test via Monitorix-general wrote:
> Hi,
> 
> 
> OS versions are Debian 10 & Debian 11.
> 
> 
> Using this repository
> 
> deb https://apt.izzysoft.de/ubuntu <https://apt.izzysoft.de/ubuntu> 

> generic universe
> 
> 
> I have a script running every night updating all servers.
> 
> apt-get update && apt-get full-upgrade -y
> 
> 
> I checked the /var/log/monitorix-httpd
> 
> My automated reports are sent at midnight,
> 
> and it looks like this the day before and the day after the 3.14.0 update
> 
> 
> Tue Jan 18 00:00:01 2022 - OK - [127.0.0.1] "GET 
> /monitorix-cgi/monitorix.cgi - libwww-perl/6.52"
> Tue Jan 18 00:00:02 2022 - OK - [127.0.0.1] "GET 
> /monitorix/imgs/system1.1day.png - libwww-perl/6.52"
> Tue Jan 18 00:00:02 2022 - OK - [127.0.0.1] "GET 
> /monitorix/imgs/system2.1day.png - libwww-perl/6.52"
> Tue Jan 18 00:00:02 2022 - OK - [127.0.0.1] "GET 
> /monitorix/imgs/system3.1day.png - libwww-perl/6.52"
> Tue Jan 18 00:00:02 2022 - OK - [127.0.0.1] "GET 
> /monitorix/imgs/system4.1day.png - libwww-perl/6.52"
> Tue Jan 18 00:00:02 2022 - OK - [127.0.0.1] "GET 
> /monitorix/imgs/system5.1day.png - libwww-perl/6.52"
> Tue Jan 18 00:00:02 2022 - OK - [127.0.0.1] "GET 
> /monitorix-cgi/monitorix.cgi - libwww-perl/6.52"
> Tue Jan 18 00:00:02 2022 - OK - [127.0.0.1] "GET 
> /monitorix/imgs/fs01.1day.png - libwww-perl/6.52"
> Tue Jan 18 00:00:02 2022 - OK - [127.0.0.1] "GET 
> /monitorix/imgs/fs02.1day.png - libwww-perl/6.52"
> Tue Jan 18 00:00:02 2022 - OK - [127.0.0.1] "GET 
> /monitorix/imgs/fs03.1day.png - libwww-perl/6.52"
> Tue Jan 18 00:00:02 2022 - OK - [127.0.0.1] "GET 
> /monitorix/imgs/fs04.1day.png - libwww-perl/6.52"
> Fri Jan 19 00:00:01 2022 - OK - [127.0.0.1] "GET 
> /monitorix-cgi/monitorix.cgi - libwww-perl/6.52"
> Fri Jan 19 00:00:02 2022 - NOTEXIST - [127.0.0.1] File does not exist: /
> Fri Jan 19 00:00:02 2022 - NOTEXIST - [127.0.0.1] File does not exist: /
> Fri Jan 19 00:00:02 2022 - NOTEXIST - [127.0.0.1] File does not exist: /
> Fri Jan 19 00:00:02 2022 - NOTEXIST - [127.0.0.1] File does not exist: /
> Fri Jan 19 00:00:02 2022 - NOTEXIST - [127.0.0.1] File does not exist: /
> Fri Jan 19 00:00:02 2022 - OK - [127.0.0.1] "GET 
> /monitorix-cgi/monitorix.cgi - libwww-perl/6.52"
> Fri Jan 19 00:00:02 2022 - NOTEXIST - [127.0.0.1] File does not exist: /
> Fri Jan 19 00:00:02 2022 - NOTEXIST - [127.0.0.1] File does not exist: /
> Fri Jan 19 00:00:02 2022 - NOTEXIST - [127.0.0.1] File does not exist: /
> Fri Jan 19 00:00:02 2022 - NOTEXIST - [127.0.0.1] File does not exist: /
> Sat Jan 20 00:00:02 2022 - OK - [127.0.0.1] "GET 
> /monitorix-cgi/monitorix.cgi - libwww-perl/6.52"
> 
> 
> Regards
> 
> 
> /Michael
> 
> 
>     Hi,
> 
>     I've updated dozens of servers without any problem so far. If you can
>     bring more information about the OS you are using and how did you update
>     Monitorix, perhaps I could give some help.
> 
>     Just let me know.
>     Regards.
> 
> 
> 
>     On 1/29/22 15:22, Micke Test via Monitorix-general wrote:
>     > Hi,
>     > 
>     > 
>     > I've been using Monitorix for about a year now and everything has been 
>     > working great.
>     > 
>     > But after the update January 18 2022, my reports no longer contain any 
>     > graphs.
>     > 
>     > 
>     > Is this feature broken in 3.14.0 or is there a workaround?
>     > 
>     > 
>     > 
>     > Thanks,
>     > 
>     > 
>     > /Michael
> 

-- 
Jordi Sanfeliu
FIBRANET Network Services Provider
https://www.fibranet.cat

_______________________________________________
Monitorix-general mailing list
Mon...@li...
https://lists.sourceforge.net/lists/listinfo/monitorix-general

Re: [Monitorix-general] Reports no longer working

Monitorix is a system monitoring tool

Re: [Monitorix-general] Reports no longer working