Thread: [Mon-devel] Proper protocol for patch submission?
Brought to you by:
trockij
From: Augie S. <aug...@gm...> - 2007-03-22 18:43:24
|
What is the proper protocol for submitting patches? Send patch here? Submit bug report to the Source Forge project page, and include a patch and send the patch here? -- Augie Schwer - Augie@Schwer.us - http://schwer.us Key fingerprint = 9815 AE19 AFD1 1FE7 5DEE 2AC3 CB99 2784 27B0 C072 |
From: Ed R. <er...@pa...> - 2007-03-22 18:57:27
|
On Thu, Mar 22, 2007 at 10:43:17AM -0800, Augie Schwer wrote: > What is the proper protocol for submitting patches? Send patch here? Yes, but... > Submit bug report to the Source Forge project page, and include a > patch and send the patch here? I like that better - put the patches in SourceForge for the record, but tell the list so that anyone who cares can chime in. For example, those patches to mon.cgi looked mighty familiar - I made them myself and reported the problem when I upgraded to the current level of Mon. We definitely need a bit more discipline about getting fixes into CVS. |
From: Augie S. <aug...@gm...> - 2007-03-22 19:16:21
|
On 3/22/07, Ed Ravin <er...@pa...> wrote: > On Thu, Mar 22, 2007 at 10:43:17AM -0800, Augie Schwer wrote: > > What is the proper protocol for submitting patches? Send patch here? > > Submit bug report to the Source Forge project page, and include a > > patch and send the patch here? > I like that better - put the patches in SourceForge for the record, > but tell the list so that anyone who cares can chime in. For example, > those patches to mon.cgi looked mighty familiar - I made them myself > and reported the problem when I upgraded to the current level of Mon. > We definitely need a bit more discipline about getting fixes into CVS. Sounds good; I'll gather my patches and go hunting around on the SF project page before submitting them there. -- Augie Schwer - Augie@Schwer.us - http://schwer.us Key fingerprint = 9815 AE19 AFD1 1FE7 5DEE 2AC3 CB99 2784 27B0 C072 |
From: Jim T. <tr...@ar...> - 2007-03-22 20:01:17
|
On Thu, 22 Mar 2007, Ed Ravin wrote: > On Thu, Mar 22, 2007 at 10:43:17AM -0800, Augie Schwer wrote: >> What is the proper protocol for submitting patches? Send patch here? > > Yes, but... > >> Submit bug report to the Source Forge project page, and include a >> patch and send the patch here? > > I like that better - put the patches in SourceForge for the record, > but tell the list so that anyone who cares can chime in. For example, > those patches to mon.cgi looked mighty familiar - I made them myself > and reported the problem when I upgraded to the current level of Mon. ...ok, but which mon.cgi? Probably not this one: http://moncgi.sourceforge.net/ Ryan Clark's done a lot of work on it. He CSSized it, gave it a config file, and it looks like the code he released in December even has fancy Javascript stuff. |
From: Augie S. <aug...@gm...> - 2007-03-23 17:12:21
|
On 3/22/07, Jim Trocki <tr...@ar...> wrote: > On Thu, 22 Mar 2007, Ed Ravin wrote: > > On Thu, Mar 22, 2007 at 10:43:17AM -0800, Augie Schwer wrote: > >> What is the proper protocol for submitting patches? Send patch here? > >> Submit bug report to the Source Forge project page, and include a > >> patch and send the patch here? > > I like that better - put the patches in SourceForge for the record, > > but tell the list so that anyone who cares can chime in. For example, > > those patches to mon.cgi looked mighty familiar - I made them myself > > and reported the problem when I upgraded to the current level of Mon. > ...ok, but which mon.cgi? Probably not this one: > http://moncgi.sourceforge.net/ For what it's worth all the mon.cgis I have seen have the same bug and won't be able to display ack comments with the new mon daemon running, so the patch I submitted would apply to Ryan's code. -- Augie Schwer - Augie@Schwer.us - http://schwer.us Key fingerprint = 9815 AE19 AFD1 1FE7 5DEE 2AC3 CB99 2784 27B0 C072 |