mon-devel

[Mon-devel] _last_checked?

[Tim K. <tkp...@ti...>]

Subroutine proc_cleanup() contains a reference to _last_checked .
Shouldn't that be _last_check instead?  I can't find any other
reference to _last_checked in the mon code.

Tim

Re: [Mon-devel] _last_checked?

[David N. <vit...@cm...>]

--On Tuesday, July 06, 2004 8:55 AM -0500 Tim Klein 
<tkp...@ti...> wrote:

> Subroutine proc_cleanup() contains a reference to _last_checked .
> Shouldn't that be _last_check instead?  I can't find any other
> reference to _last_checked in the mon code.

At first glance, that certainly looks like a bug.

However its not completely clear if the typo should be fixed or the
line deleted.

run_monitor() sets _last_check and _next_check
proc_cleanup() sets _last_failure or _last_success

_last_check is never used internal to Mon, except to set _next_check

So, changing proc_cleanup() to set _next_check when a monitor script exits 
will only result in the timestamp passed to Mon clients being when the 
script exited instead of when it was started.  But when it exited is 
actually already available as either _last_success or _last_failure.  But 
having _last_check be when the script was started might be interesting for 
purposes of calculating how long mon scripts are taking to run.

I'd lean towards deleting the line from proc_cleanup.

Jim?

-David

David Nolan                    <*>                    vit...@cm...
curses: May you be forced to grep the termcap of an unclean yacc while
      a herd of rogue emacs fsck your troff and vgrind your pathalias!

Re: [Mon-devel] _last_checked?

[Jim T. <tr...@tr...>]

On Tue, 6 Jul 2004, David Nolan wrote:

> So, changing proc_cleanup() to set _next_check when a monitor script exits 
> will only result in the timestamp passed to Mon clients being when the 
> script exited instead of when it was started.  But when it exited is 
> actually already available as either _last_success or _last_failure.  But 
> having _last_check be when the script was started might be interesting for 
> purposes of calculating how long mon scripts are taking to run.

> I'd lean towards deleting the line from proc_cleanup.

better yet, just make that line be this instead:

        $sref->{"_monitor_duration"} = $tmnow - $sref->{"_last_check"};

and make this change in client_write_opstatus:

    $buf .= " interval=$sref->{interval}" .
            " monitor_duration=$sref->{_monitor_duration}"
        if ($sref->{"interval"});

then you can get that "how long did it run" info if you want. afaik
nobody has requested that feature, but i can see how it could be useful
if you're trying to tune your config or if you are debugging something
monitor-related.

Re: [Mon-devel] _last_checked?

[Jim T. <tr...@tr...>]

On Tue, 6 Jul 2004, Tim Klein wrote:

> Subroutine proc_cleanup() contains a reference to _last_checked .
> Shouldn't that be _last_check instead?  I can't find any other
> reference to _last_checked in the mon code.

yeah that's a bug. i fixed it in my mon-1-0-0pre1 sandbox, and i'll
check it in later.