Re: [Mon-devel] upalertafter broken
Brought to you by:
trockij
From: Wolfram S. <li...@wo...> - 2007-11-30 10:01:03
|
* Jim Trocki <tr...@ar...> [2007-11-15 19:36]: > On Tue, 9 Oct 2007, Wolfram Schlich wrote: > >> 'upalertafter' is only supported for period definitions, not for >> service definitions itself. Despite that fact, process_event() >> (mon line 3365) looks for $sref->{"upalertafter"}, which obviously >> doesn't exist. > > correct. this is part of the bug. > >> A place where the code loops through the periods and where one >> could check it is within the do_alert() function. > > correct again. the upalertafter processing is being handled in the wrong > place. > a while back i had cleaned up the code to make the trap processing use the > same > squelch logic as the other processing by putting that in process_event. > this > fixed some trap bugs, and i had intended to do some more cleanup related to > that. so it does appear that the way to fix this is to rip out the > decisions to > call do_alert from process_event and stick them into do_alert. > >> Unfortunately, when you place the upalertafter check in there, >> it will only be run once, because process_event() already resets > > sure, just some minor details :) > > david, have you had a look at this yet, and have you formulated an opinion > on > this? i'll move on this, but just let us know if you have some ideas. Hi, I really don't want to bother you, but: any news on this upalertafter bug? :o) -- Regards, Wolfram Schlich <wsc...@ge...> Gentoo Linux * http://dev.gentoo.org/~wschlich/ |