[Mon-devel] refinement for ackalerts
Brought to you by:
trockij
From: Ed R. <er...@pa...> - 2005-05-06 23:27:08
|
I love the ackalerts, but they're going out even if someone acknowledges a problem before the down alert has been issued. This patch fixes that: @@ -629,9 +629,9 @@ # skip upalerts not paired with down alerts # disable by setting "no_comp_alerts" in period section # - if (!$pref->{"no_comp_alerts"} && ($flags & $FL_UPALERT) && !$pref->{"_alert_sent"}) + if (!$pref->{"no_comp_alerts"} && ($flags & ($FL_UPALERT | $FL_ACKALERT)) && !$pref->{"_alert_sent"}) { - syslog ('debug', "$group/$service/$periodlabel: Suppressing upalert since no down alert was sent."); + syslog ('debug', "$group/$service/$periodlabel: Suppressing upalert or ackalert since no down alert was sent."); next; } But I think it's insufficient - we should probably include disablealerts, since that's also an operator action that no one needs to hear about if the operator is doing it to keep something from alarming. -- Ed |