Re: [Mon-devel] mon 1.1-pre1 dependencies broken?

[David N. <vit...@cm...>]

--On Sunday, April 24, 2005 3:23 AM -0400 Ed Ravin <er...@pa...> wrote:

> And I had to retreat shortly afterwards - alert dependencies weren't
> working. Alerts weren't being called because depstatus was always
> undefined.  I tracked the problem down to this code in process_event:
>
>    3203     if ($sref->{"depend"} ne "" &&
>    3204             $sref->{"dep_behavior"} eq "a")
>    3205     {
>    3206         dep_ok ($sref);
>    3207     }
>
> Ahem.  Cough cough.  Shouldn't line 3206 be:
>
>
>    3206         dep_ok ($sref, 'a');
>
>
> It works a hell of a lot better now.  I'm kicking myself for not
> catching this in my preproduction testing - none of the watch entries
> I tested with used dependencies.  Who's using Mon-1.1-pre1?  Why didn't
> they notice this?
>
> Jim, David, is this the right fix?
>

It looks correct to me.  Looks like a bug that appeared in mon-1.0-pre* 
when Jim did the process_event conversion.  I'll commit that fix now.

-David

David Nolan                    <*>                    vit...@cm...
curses: May you be forced to grep the termcap of an unclean yacc while
      a herd of rogue emacs fsck your troff and vgrind your pathalias!