Re: [Mon-devel] Today's Mon 1.1 nits
Brought to you by:
trockij
From: David N. <vit...@cm...> - 2005-02-17 14:07:51
|
--On Wednesday, February 16, 2005 7:41 PM -0500 Ed Ravin <er...@pa...> wrote: > This is a problem in Mon 1.0 also - that extra backslash shouldn't be > there: > > -if ($^O eq "linux" || $^O =~ /^(open|free|net)bsd\$/ || $^O eq "aix") > +if ($^O eq "linux" || $^O =~ /^(open|free|net)bsd$/ || $^O eq "aix") > > Without this fix syslog goes to UDP (and therefore gets lost) on the BSDs. > I'll commit that fix shortly... > ------------------------ > > This is a feature I added to allow the user to define a different path > for the M4 processor. I'm probably the only person who needs this, so > it doesn't need to go into 1.0: > > - if (!open (CFG, "m4 $CF |")); > + if (!open (CFG, > + (exists($ENV{'MON_M4'}) ? $ENV{'MON_M4'} : "m4") > . " $CF |") ); > > I like Peter's solution to this better, especially since Mon is not currently directly using any other environment variables that are passed in to it. But it changes the semantics of -M, in that it now requires the m4 path argument. Getopt::Std doesn't provide an option with optional argument, as far as I can tell. If I convert mon to using Getopt::Long then we can make the argument to -M optional. I'm doing that now... Ooh, and I found a couple errors in the process. -k was documented but not processed, and -O and -o were processed but not used. I've add -k, fixed -O, and purged -o. Committing now... -David David Nolan <*> vit...@cm... curses: May you be forced to grep the termcap of an unclean yacc while a herd of rogue emacs fsck your troff and vgrind your pathalias! |