|
From: Jens H. <je...@St...> - 1996-07-26 07:19:33
|
Hi, > I've just found a nasty bug, which prevented module unload from working > (perhaps only when compiled with gcc, had no time to check this). The > problem is a strcpy() with overlapping regions (gcc -fbounds-checking told > me, its great) in cmdPath.c. I changed it to a memmove, and the bug > vanished (on Solaris-2.5 and Linux). > > Greetings, Swen > > Here is the fix: > > --- cmdPath.c.orig Fri Jul 1 01:17:13 1994 > +++ cmdPath.c Thu Jul 25 15:32:51 1996 > @@ -363,8 +363,9 @@ > We must be in SW_STATE3 or not in SW_STATE at all. > Removing the marker should be just like removing any other path. > */ > - strcpy(oldpath + ((regexpPtr->startp[0] + start_offset) - oldpath), > - oldpath + ((regexpPtr->endp[0]) - oldpath)); > + memmove(oldpath + ((regexpPtr->startp[0] + start_offset) - oldpath), > + oldpath + ((regexpPtr->endp[0]) - oldpath), > + strlen(oldpath + ((regexpPtr->endp[0]) - oldpath)) + 1); > > /* > * Cache the set. Clear the variable from the unset table just Did you try modules-3.0pre? It's available at ftp://ftp.connectde.net/sysadmin/sw-admininstration/modules. Ciao -- Jens -------------------------------------------------------------------------------- / +##+|##+ STRAWBERRY Jens Hamisch +v#+v v##+ EDV-Systeme GmbH Managing director / v v\v | . . . | Brauneckweg 2 Car (Voice): (+49 172) 81 04 162 | . | D-82549 Koenigsdorf Voice: (+49 8179) 5278 Q, Fax | . | Email: je...@St... \ . / Tel./Fax: (+49 8179) 5278 je...@Co... \____/ Str...@St... Home (Email): je...@le... |
