module-build-general

[Module-build-general] Couple of code changes

[Ken W. <ke...@ma...>]

Hey,

A couple of recent code changes I committed to CVS:

  1) Actions now run only once per dispatch() invocation.  Dave, maybe 
this means the 'distmeta' interaction with the 'distdir' stuff could be 
cleaned up some?  I suppose there's no real reason to fix things that 
aren't broken, though.

  2) I change the instance() method to current(), since it's not really 
a true Singleton pattern, and I added docs for current() and notes().

  -Ken

Re: [Module-build-general] Couple of code changes

[Steve P. <sp...@qu...>]

On Wednesday, August 6, 2003, at 07:25  pm, Ken Williams wrote:

> ...
>  1) Actions now run only once per dispatch() invocation.  Dave, maybe 
> this means the 'distmeta' interaction with the 'distdir' stuff could 
> be cleaned up some?  I suppose there's no real reason to fix things 
> that aren't broken, though.

Au contraire - consistency is one good reason to refactor.

-Steve

Re: [Module-build-general] Couple of code changes

[Dave R. <au...@ur...>]

On Fri, 8 Aug 2003, Steve Purkis wrote:

> On Wednesday, August 6, 2003, at 07:25  pm, Ken Williams wrote:
>
> > ...
> >  1) Actions now run only once per dispatch() invocation.  Dave, maybe
> > this means the 'distmeta' interaction with the 'distdir' stuff could
> > be cleaned up some?  I suppose there's no real reason to fix things
> > that aren't broken, though.
>
> Au contraire - consistency is one good reason to refactor.

As long as there are tests, it doesn't hurt to change it.


-dave

/*=======================
House Absolute Consulting
www.houseabsolute.com
=======================*/