module-build-general

[Module-build-general] dist dir is just symlinks?!

[Dave R. <au...@ur...>]

Bleah, that sucks!  Whoever wrote EU::Manifest needs to be beaten.

Anyway, Ken, how do you feel about changing line 1414 from

  ExtUtils::Manifest::manicopy($dist_files, $dist_dir, 'best');

to

  ExtUtils::Manifest::manicopy($dist_files, $dist_dir, 'cp');

Otherwise I can't munge stuff in the dist dir, because I'm actually
munging stuff in the real base dir, which is _really_ annoying.


-dave

/*=======================
House Absolute Consulting
www.houseabsolute.com
=======================*/

[Module-build-general] Re: dist dir is just symlinks?!

[Dave R. <au...@ur...>]

On Mon, 28 Jul 2003, Dave Rolsky wrote:

> Bleah, that sucks!  Whoever wrote EU::Manifest needs to be beaten.
>
> Anyway, Ken, how do you feel about changing line 1414 from
>
>   ExtUtils::Manifest::manicopy($dist_files, $dist_dir, 'best');
>
> to
>
>   ExtUtils::Manifest::manicopy($dist_files, $dist_dir, 'cp');
>
> Otherwise I can't munge stuff in the dist dir, because I'm actually
> munging stuff in the real base dir, which is _really_ annoying.

Here's a good one.  If you set the copying method to 'cp' it changes the
permissions on the copied files to remove write permission.  Just
brilliant, really.  After all, it's inconceivable that anyone might need
to ever alter these files.


Grr....

This I can work around, I guess.


-dave

/*=======================
House Absolute Consulting
www.houseabsolute.com
=======================*/

Re: [Module-build-general] dist dir is just symlinks?!

[Andreas J K. <and...@an...>]

>>>>> On Mon, 28 Jul 2003 17:44:56 -0500 (CDT), Dave Rolsky <au...@ur...> said:

 dr> Bleah, that sucks!  Whoever wrote EU::Manifest needs to be beaten.

Me, Me!

 dr> Here's a good one.  If you set the copying method to 'cp' it changes the
 dr> permissions on the copied files to remove write permission.  Just
 dr> brilliant, really.  After all, it's inconceivable that anyone might need
 dr> to ever alter these files.

I apologise for not documenting this behaviour. But please consider
the age of the code base and the original target audience. I wrote it
~7 years ago and the only place it was used was for the 'make dist'
target of MakeMaker. At that time everybody agreed that we should
C<chmod -w> all files in a distribution file for CPAN.

-- 
andreas

Re: [Module-build-general] dist dir is just symlinks?!

[Dave R. <au...@ur...>]

On Fri, 1 Aug 2003, Andreas J Koenig wrote:

> >>>>> On Mon, 28 Jul 2003 17:44:56 -0500 (CDT), Dave Rolsky <au...@ur...> said:
>
>  dr> Bleah, that sucks!  Whoever wrote EU::Manifest needs to be beaten.
>
> Me, Me!

That's it, I'm gonna get ya!

>  dr> Here's a good one.  If you set the copying method to 'cp' it changes the
>  dr> permissions on the copied files to remove write permission.  Just
>  dr> brilliant, really.  After all, it's inconceivable that anyone might need
>  dr> to ever alter these files.
>
> I apologise for not documenting this behaviour. But please consider
> the age of the code base and the original target audience. I wrote it
> ~7 years ago and the only place it was used was for the 'make dist'
> target of MakeMaker. At that time everybody agreed that we should
> C<chmod -w> all files in a distribution file for CPAN.

Yeah, I know the origins.  Sorry for the rant.  I was just frustrated
after spending some time figuring out why every time I changed a file in
the dist dir, I saw changes under the base directory.

Anyway, I think having M::B use the 'cp' mode is fine for now.  Maybe we
can add a 'clean' mode in the future which just copies and doesn't tweak
permissions.


-dave

/*=======================
House Absolute Consulting
www.houseabsolute.com
=======================*/