Thread: [Module-build-general] Tests on perl 5.005

SourceForge Headquarters 1320 Columbia Street Suite 310 San Diego, CA 92101 +1 (858) 422-6466

Hi,

Does someone have a perl 5.005 that they could test the current 
Module::Build from CVS on?  I'd like to close bug 2302 at 
http://rt.cpan.org/Ticket/Display.html?id=2302 .

  -Ken




On Fri, 9 May 2003, Ken Williams wrote:

> Does someone have a perl 5.005 that they could test the current
> Module::Build from CVS on?  I'd like to close bug 2302 at
> http://rt.cpan.org/Ticket/Display.html?id=2302 .

I do, but the current CVS is quite broken.  With the patch below sig it
gives this with 5.00503:

t/basic.........ok
t/compat........ok
t/runthrough....ok 8/19Module::Info was not available, no 'provides' will
be created in META.yml at blib/lib/Module/Build/Base.pm line 1186.
Use of uninitialized value at
/home/autarch/Module-Build/blib/lib/Module/Build/Base.pm line 627.
Use of uninitialized value at
/home/autarch/Module-Build/blib/lib/Module/Build/Base.pm line 628.
t/runthrough....ok 10/19Module::Info was not available, no 'provides' will
be created in META.yml at blib/lib/Module/Build/Base.pm line 1186.
t/runthrough....ok 16/19Warning: You do not have permissions to install
into /usr/local/perl5.00503/lib/site_perl/5.005 at
/usr/local/perl5.00503/lib/5.00503/ExtUtils/Install.pm line 61.
t/runthrough....FAILED test 18
        Failed 1/19 tests, 94.74% okay
t/xs............ok


Everything passes with 5.8.0, but I still get an uninit warning at line
628.


/*=======================
House Absolute Consulting
www.houseabsolute.com
=======================*/

--- Base.pm.~1.110.~	2003-05-08 11:50:30.000000000 -0500
+++ Base.pm	2003-05-09 13:50:32.000000000 -0500
@@ -569,7 +569,7 @@
   },
 );

-\$build->dispatch;
+\$build->dispatch(\@ARGV);
 EOF
 }





On Friday, May 9, 2003, at 01:53  PM, Dave Rolsky wrote:

> On Fri, 9 May 2003, Ken Williams wrote:
>
>> Does someone have a perl 5.005 that they could test the current
>> Module::Build from CVS on?  I'd like to close bug 2302 at
>> http://rt.cpan.org/Ticket/Display.html?id=2302 .
>
> I do, but the current CVS is quite broken.

Oops, I'd meant to back out a change I accidentally committed before.  
Here's a patch:

=========================================
--- lib/Module/Build/Base.pm    8 May 2003 14:22:24 -0000       1.110
+++ lib/Module/Build/Base.pm    9 May 2003 18:58:49 -0000
@@ -614,10 +614,9 @@

  sub dispatch {
    my $self = shift;
-  local $self->{action} = shift;

    if (@_) {
-    my %p = @_;
+    ($self->{action}, my %p) = @_;
      my $args = $p{args} ? delete($p{args}) : {};

      $self->{args} = {%{$self->{args}}, %$args};
=========================================

I've committed this now.

What's it look like with this & 5.005 now?


  -Ken




On Fri, 9 May 2003, Ken Williams wrote:

> What's it look like with this & 5.005 now?

Same test fails, runthrough.t #18.

Patch below sig.  I think the "values %hash" construct didn't make aliases
in 5.00503.


-dave

/*=======================
House Absolute Consulting
www.houseabsolute.com
=======================*/

--- Base.pm.~1.111.~	2003-05-09 14:07:10.000000000 -0500
+++ Base.pm	2003-05-09 14:10:06.000000000 -0500
@@ -1253,11 +1253,13 @@
   }

   if (length(my $destdir = $self->{properties}{destdir} || '')) {
-    $_ = File::Spec->catdir($destdir, $_) foreach values %map;
+    foreach (keys %map) {
+      $map{$_} = File::Spec->catdir($destdir, $map{$_});
+    }
   }

   $map{read} = '';  # To keep ExtUtils::Install quiet
-
+
   return \%map;
 }





On Friday, May 9, 2003, at 02:10  PM, Dave Rolsky wrote:

> On Fri, 9 May 2003, Ken Williams wrote:
>
>> What's it look like with this & 5.005 now?
>
> Same test fails, runthrough.t #18.
>
> Patch below sig.  I think the "values %hash" construct didn't make 
> aliases
> in 5.00503.

Ugh, applied.

  -Ken




* Dave Rolsky (au...@ur...) [10 May 2003 05:13]:

[...]
> Patch below sig.  I think the "values %hash" construct didn't make
> aliases in 5.00503.

I can confirm it doesn't.

Found that out when testing DateTime::Format::Builder under 5.005_03.



cheers,
-- 
Iain.




Thread: [Module-build-general] Tests on perl 5.005

module-build-general