module-build-general

[Module::Build] [patch] cccdlflags

[Richard C. <ric...@un...>]

I have a ticket against Pod::Coverage[0] which I think to be a
Module::Build issue, namely when invoking the C compiler the -fpic
from $Config{cccdlflags} isn't propagated to the cc command line as
MakeMaker does.

Attached is a minimal patch for this - it doesn't disturb any of the
existing XS tests, but I have a feeling it's correct by examining
ExtUtils::MM_Unix

[0] http://rt.cpan.org/NoAuth/Bug.html?id=4157

-- 
Richard Clamp <ric...@un...>

Re: [Module::Build] [patch] cccdlflags

[Richard C. <ric...@un...>]

On Mon, Oct 20, 2003 at 04:48:29PM +0200, Mathieu Arnold wrote:
> Hey, that's my ticket :)
> If someone here needs some testings on a amd64 box, I'll be glad to run
> them for you.

I'd expect that running of the t/xs.t should have already exposed the
issue on your build box, but I don't see an errorlog for
Module::Build.  Are successful build logs discarded, or would I have
to look somewhere else for those?

-- 
Richard Clamp <ric...@un...>

Re: [Module::Build] [patch] cccdlflags

[Mathieu A. <ma...@Fr...>]

+-Le 20/10/2003 16:07 +0100, Richard Clamp =E9crivait :
| On Mon, Oct 20, 2003 at 04:48:29PM +0200, Mathieu Arnold wrote:
|> Hey, that's my ticket :)
|> If someone here needs some testings on a amd64 box, I'll be glad to run
|> them for you.
|=20
| I'd expect that running of the t/xs.t should have already exposed the
| issue on your build box, but I don't see an errorlog for
| Module::Build.  Are successful build logs discarded, or would I have
| to look somewhere else for those?

I'd say that it's there :
<http://bento.freebsd.org/errorlogs/amd64-5-latest-logs/p5-Module-Build-0.2
1.log>
And build don't make test.
I'll try to run make test on this box.

--=20
Mathieu Arnold

Re: [Module::Build] [patch] cccdlflags

[Mathieu A. <ma...@Fr...>]

+-Le 20/10/2003 13:29 +0100, Richard Clamp =E9crivait :
| I have a ticket against Pod::Coverage[0] which I think to be a
| Module::Build issue, namely when invoking the C compiler the -fpic
| from $Config{cccdlflags} isn't propagated to the cc command line as
| MakeMaker does.
|=20
| Attached is a minimal patch for this - it doesn't disturb any of the
| existing XS tests, but I have a feeling it's correct by examining
| ExtUtils::MM_Unix

Hey, that's my ticket :)
If someone here needs some testings on a amd64 box, I'll be glad to run
them for you.

--=20
Mathieu Arnold

Re: [Module::Build] [patch] cccdlflags

[Ken W. <ke...@ma...>]

Thanks, applied.

  -Ken

On Monday, October 20, 2003, at 07:29  AM, Richard Clamp wrote:

> I have a ticket against Pod::Coverage[0] which I think to be a
> Module::Build issue, namely when invoking the C compiler the -fpic
> from $Config{cccdlflags} isn't propagated to the cc command line as
> MakeMaker does.
>
> Attached is a minimal patch for this - it doesn't disturb any of the
> existing XS tests, but I have a feeling it's correct by examining
> ExtUtils::MM_Unix
>
> [0] http://rt.cpan.org/NoAuth/Bug.html?id=4157
>
> -- 
> Richard Clamp <ric...@un...>
> <cccdlflags.patch>