module-build-general

[Module::Build] Re: [Module-build-checkins] [svn:Module-Build] r5869 - Module-Build/trunk/t

[Ken W. <ke...@ma...>]

I'm not sure about this one - it seems weird to set the path with  
Unix-like syntax but get the result in local syntax.

Can we take a little pause to review the APIs for this family of  
methods?  I think there's also some inconsistency between  
install_base_* and prefix_*, from back when I was a little confused  
about them.

  -Ken


On Apr 6, 2006, at 10:31 PM, ra...@cv... wrote:

> Author: randys
> Date: Thu Apr  6 20:31:02 2006
> New Revision: 5869
>
> Modified:
>    Module-Build/trunk/t/destinations.t
>
> Log:
> Fixup some cross-platform paths.
>
> Modified: Module-Build/trunk/t/destinations.t
> ====================================================================== 
> ========
> --- Module-Build/trunk/t/destinations.t	(original)
> +++ Module-Build/trunk/t/destinations.t	Thu Apr  6 20:31:02 2006
> @@ -92,10 +92,10 @@
>      like( $@, qr/Value must be a relative path/, '  emits error if  
> path not relative' );
>
>      $path = $mb->install_base_relpaths('elem' => 'foo/bar');
> -    is( $path, 'foo/bar', '  returns assigned path' );
> +    is( $path, catdir(qw(foo bar)), '  returns assigned path' );
>
>      $path = $mb->install_base_relpaths('elem');
> -    is( $path, 'foo/bar', '  can read stored path' );
> +    is( $path, catdir(qw(foo/bar)), '  can read stored path' );
>
>      $map = $mb->install_base_relpaths();
>      is_deeply( $map->{elem}, [qw(foo bar)], '  can access map' );
> @@ -121,10 +121,10 @@
>      like( $@, qr/Value must be a relative path/, '  emits error if  
> path not relative' );
>
>      $path = $mb->prefix_relpaths('site', 'elem' => 'foo/bar');
> -    is( $path, 'foo/bar', '  returns assigned path' );
> +    is( $path, catdir(qw(foo bar)), '  returns assigned path' );
>
>      $path = $mb->prefix_relpaths('site', 'elem');
> -    is( $path, 'foo/bar', '  can read stored path' );
> +    is( $path, catdir(qw(foo bar)), '  can read stored path' );
>
>      $map = $mb->prefix_relpaths();
>      is_deeply( $map->{elem}, [qw(foo bar)], '  can access map' );
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by xPML, a groundbreaking scripting  
> language
> that extends applications into web and mobile media. Attend the  
> live webcast
> and join the prime developer group breaking into this new coding  
> territory!
> http://sel.as-us.falkag.net/sel? 
> cmd=lnk&kid=110944&bid=241720&dat=121642
> _______________________________________________
> Module-build-checkins mailing list
> Mod...@li...
> https://lists.sourceforge.net/lists/listinfo/module-build-checkins

Re: [Module::Build] Re: [Module-build-checkins] [svn:Module-Build] r5869 - Module-Build/trunk/t

[Randy W. S. <ml...@th...>]

Ken Williams wrote:
> I'm not sure about this one - it seems weird to set the path with 
> Unix-like syntax but get the result in local syntax.
> 
> Can we take a little pause to review the APIs for this family of 
> methods?  I think there's also some inconsistency between install_base_* 
> and prefix_*, from back when I was a little confused about them.

Yeah, I guess it does seem weird. I wanted to avoid passing in an array 
of path names because it seemed a bit clunky. Since it will be used by 
authors and be expected to work on all platforms, it seemed natural to 
pass in a nutrual, single-style path syntax. I chose unix like paths 
since we do this elsewhere.

That leaves the return value. I figured the return value should be 
immediately usable without the author having to perform the conversion 
from unix to a localized path, so I performed the conversion before 
returning.

The logic made sense to me as I was doing it, but the end result, at 
first glance, does seem unusual.

Randy.

Re: [Module::Build] Re: [Module-build-checkins] [svn:Module-Build] r5869 - Module-Build/trunk/t

[Stephen A. <spa...@gm...>]

Hi,

I think this is a topic I am very interested in.

1. Can you direct us to the documentation that describes the capabilities
    that we are pausing to review?
    (And which methods make up "this family of methods"?)

2. If it is not documented, may I suggest that the first order of business =
is
    to document it so that we may pause to review it together?

Thanks,
Stephen

On 4/7/06, Ken Williams <ke...@ma...> wrote:
> I'm not sure about this one - it seems weird to set the path with
> Unix-like syntax but get the result in local syntax.
>
> Can we take a little pause to review the APIs for this family of
> methods?  I think there's also some inconsistency between
> install_base_* and prefix_*, from back when I was a little confused
> about them.
>
>   -Ken
>
>
> On Apr 6, 2006, at 10:31 PM, ra...@cv... wrote:
>
> > Author: randys
> > Date: Thu Apr  6 20:31:02 2006
> > New Revision: 5869
> >
> > Modified:
> >    Module-Build/trunk/t/destinations.t
> >
> > Log:
> > Fixup some cross-platform paths.
> >
> > Modified: Module-Build/trunk/t/destinations.t
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > =3D=3D=3D=3D=3D=3D=3D=3D
> > --- Module-Build/trunk/t/destinations.t       (original)
> > +++ Module-Build/trunk/t/destinations.t       Thu Apr  6 20:31:02 2006
> > @@ -92,10 +92,10 @@
> >      like( $@, qr/Value must be a relative path/, '  emits error if
> > path not relative' );
> >
> >      $path =3D $mb->install_base_relpaths('elem' =3D> 'foo/bar');
> > -    is( $path, 'foo/bar', '  returns assigned path' );
> > +    is( $path, catdir(qw(foo bar)), '  returns assigned path' );
> >
> >      $path =3D $mb->install_base_relpaths('elem');
> > -    is( $path, 'foo/bar', '  can read stored path' );
> > +    is( $path, catdir(qw(foo/bar)), '  can read stored path' );
> >
> >      $map =3D $mb->install_base_relpaths();
> >      is_deeply( $map->{elem}, [qw(foo bar)], '  can access map' );
> > @@ -121,10 +121,10 @@
> >      like( $@, qr/Value must be a relative path/, '  emits error if
> > path not relative' );
> >
> >      $path =3D $mb->prefix_relpaths('site', 'elem' =3D> 'foo/bar');
> > -    is( $path, 'foo/bar', '  returns assigned path' );
> > +    is( $path, catdir(qw(foo bar)), '  returns assigned path' );
> >
> >      $path =3D $mb->prefix_relpaths('site', 'elem');
> > -    is( $path, 'foo/bar', '  can read stored path' );
> > +    is( $path, catdir(qw(foo bar)), '  can read stored path' );
> >
> >      $map =3D $mb->prefix_relpaths();
> >      is_deeply( $map->{elem}, [qw(foo bar)], '  can access map' );
> >
> >
> > -------------------------------------------------------
> > This SF.Net email is sponsored by xPML, a groundbreaking scripting
> > language
> > that extends applications into web and mobile media. Attend the
> > live webcast
> > and join the prime developer group breaking into this new coding
> > territory!
> > http://sel.as-us.falkag.net/sel?
> > cmd=3Dlnk&kid=3D110944&bid=3D241720&dat=3D121642
> > _______________________________________________
> > Module-build-checkins mailing list
> > Mod...@li...
> > https://lists.sourceforge.net/lists/listinfo/module-build-checkins
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by xPML, a groundbreaking scripting langua=
ge
> that extends applications into web and mobile media. Attend the live webc=
ast
> and join the prime developer group breaking into this new coding territor=
y!
> http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D110944&bid=3D241720&dat=
=3D121642
> _______________________________________________
> Module-build-general mailing list
> Mod...@li...
> https://lists.sourceforge.net/lists/listinfo/module-build-general
>

Re: [Module::Build] Re: [Module-build-checkins] [svn:Module-Build] r5869 - Module-Build/trunk/t

[Randy W. S. <ml...@th...>]

Stephen Adkins wrote:
> Hi,
> 
> I think this is a topic I am very interested in.
> 
> 1. Can you direct us to the documentation that describes the capabilities
>     that we are pausing to review?
>     (And which methods make up "this family of methods"?)
> 
> 2. If it is not documented, may I suggest that the first order of business is
>     to document it so that we may pause to review it together?

<http://svn.perl.org/modules/Module-Build/trunk/lib/Module/Build/Authoring.pod>

Randy.

Re: [Module::Build] Re: [Module-build-checkins] [svn:Module-Build] r5869 - Module-Build/trunk/t

[Stephen A. <spa...@gm...>]

And which methods in particular make up "this family of methods" whose
collective functionality are being reviewed?

(Or alternatively, which section(s) of the quite long Authoring document
are under consideration?)

Stephen

On 4/7/06, Randy W. Sims <ml...@th...> wrote:
> Stephen Adkins wrote:
> > Hi,
> >
> > I think this is a topic I am very interested in.
> >
> > 1. Can you direct us to the documentation that describes the capabiliti=
es
> >     that we are pausing to review?
> >     (And which methods make up "this family of methods"?)
> >
> > 2. If it is not documented, may I suggest that the first order of busin=
ess is
> >     to document it so that we may pause to review it together?
>
> <http://svn.perl.org/modules/Module-Build/trunk/lib/Module/Build/Authorin=
g.pod>
>
> Randy.
>

Re: [Module::Build] Re: [Module-build-checkins] [svn:Module-Build] r5869 - Module-Build/trunk/t

[Randy W. S. <ml...@th...>]

Stephen Adkins wrote:
> And which methods in particular make up "this family of methods" whose
> collective functionality are being reviewed?
> 
> (Or alternatively, which section(s) of the quite long Authoring document
> are under consideration?)

In the "METHODS" section, the methods

  install_path
  install_base_relpaths
  prefix_relpaths