module-build-general

[Module::Build] Broken test in runthrough.t

[<and...@fr...>]

The following test is broken in bleadperl:

  my $fh = IO::File->new(File::Spec->catfile($dist->dirname, 'META.yml'));
  my $contents = do {local $/; <$fh>};
  $contents =~ /Module::Build version ([0-9_.]+)/m;
  is $1, $mb->VERSION, "Check version used to create META.yml: $1 == " . $mb->VERSION;

The last line should compensate for trailing zeroes:

  is 0+$1, 0+$mb->VERSION, "Check version used to create META.yml: $1 == " . $mb->VERSION;

Here is how the failure manifests:

t/runthrough......ok 14/28                                                   
#   Failed test 'Check version used to create META.yml: 0.2707 == 0.270700'
#   in t/runthrough.t at line 142.
#          got: '0.2707'
#     expected: '0.270700'
t/runthrough......NOK 19# Looks like you failed 1 test of 28.                
t/runthrough......dubious                                                    
        Test returned status 1 (wstat 256, 0x100)


-- 
andreas

Re: [Module::Build] Broken test in runthrough.t

[John P. <jpe...@ro...>]

Andreas J. Koenig wrote:
> The following test is broken in bleadperl:
> 
>   my $fh = IO::File->new(File::Spec->catfile($dist->dirname, 'META.yml'));
>   my $contents = do {local $/; <$fh>};
>   $contents =~ /Module::Build version ([0-9_.]+)/m;
>   is $1, $mb->VERSION, "Check version used to create META.yml: $1 == " . $mb->VERSION;
> 
> The last line should compensate for trailing zeroes:
> 
>   is 0+$1, 0+$mb->VERSION, "Check version used to create META.yml: $1 == " . $mb->VERSION;

Or better yet, stop doing *string* comparison with *numbers* (or $VERSION's):

> ok $1 == $mb->VERSION, "Check version used to create META.yml: $1 == " . $mb->VERSION;

Module::Build _will_ continue to break in various ways until it completely
understands version objects (a patch I'm working on in a different window).  The
reason for this is the code in Module::Build::ModuleInfo which tries to "ignore"
version.pm's UNIVERSAL::VERSION (in favor of the existing pre-bleadperl code).
Unfortunately for Module::Build, in bleadperl, there is *only* the correct
version-object-aware code...

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747

Re: [Module::Build] Broken test in runthrough.t

[Ken W. <ke...@ma...>]

On Feb 14, 2006, at 5:22 AM, John Peacock wrote:

> Andreas J. Koenig wrote:
>> The following test is broken in bleadperl:
>>
>>   my $fh = IO::File->new(File::Spec->catfile($dist->dirname, 
>> 'META.yml'));
>>   my $contents = do {local $/; <$fh>};
>>   $contents =~ /Module::Build version ([0-9_.]+)/m;
>>   is $1, $mb->VERSION, "Check version used to create META.yml: $1 == 
>> " . $mb->VERSION;
>>
>> The last line should compensate for trailing zeroes:
>>
>>   is 0+$1, 0+$mb->VERSION, "Check version used to create META.yml: $1 
>> == " . $mb->VERSION;
>
> Or better yet, stop doing *string* comparison with *numbers* (or 
> $VERSION's):

In my defense, all I was doing is setting a variable and checking its 
value later after it passed through a file, so the natural comparison 
seemed to be a string comparison.

In any case, I'm checking in the first part of the patch now, before I 
start thinking about the other parts.

  -Ken

Index: t/runthrough.t
===================================================================
RCS file: /cvsroot/module-build/Module-Build/t/runthrough.t,v
retrieving revision 1.64
diff -u -r1.64 runthrough.t
--- t/runthrough.t	9 Jan 2006 03:58:01 -0000	1.64
+++ t/runthrough.t	16 Feb 2006 04:05:09 -0000
@@ -139,7 +139,7 @@
    my $fh = IO::File->new(File::Spec->catfile($dist->dirname, 
'META.yml'));
    my $contents = do {local $/; <$fh>};
    $contents =~ /Module::Build version ([0-9_.]+)/m;
-  is $1, $mb->VERSION, "Check version used to create META.yml: $1 == " 
. $mb->VERSION;
+  cmp_ok $1, '==', $mb->VERSION, "Check version used to create 
META.yml: $1 == " . $mb->VERSION;

    SKIP: {
      skip( "not sure if we can create a tarball on this platform", 1 )