Thread: [Module-build-general] Win32 bug fixed?
Status: Beta
Brought to you by:
kwilliams
Menu
▾
▴
module-build-general
|
From: Ken W. <ke...@ma...> - 2003-07-07 17:31:33
|
Hi Randy etc., I think I just fixed the following bug on Win32: http://rt.cpan.org/Ticket/Display.html?id=2391 I've also added a test to t/xs.t that attempts to catch this situation. Could you (or someone else) try running the tests from the latest CVS (assuming anonymous-CVS ever catches up - it should be revision 1.8 of xs.t) on Win32 and see whether they work? Thanks. -Ken |
|
From: Randy W. S. <Ra...@Th...> - 2003-07-09 02:08:04
|
On 7/7/2003 1:31 PM, Ken Williams wrote: > Hi Randy etc., > > I think I just fixed the following bug on Win32: > > http://rt.cpan.org/Ticket/Display.html?id=2391 > > I've also added a test to t/xs.t that attempts to catch this situation. > Could you (or someone else) try running the tests from the latest CVS > (assuming anonymous-CVS ever catches up - it should be revision 1.8 of > xs.t) on Win32 and see whether they work? > > Thanks. > > -Ken > All clear... [X:\home\Administrator\projects\Module-Build] $ set TEST_SIGNATURE=1 [X:\home\Administrator\projects\Module-Build] $ perl Build.PL Checking whether your kit is complete... Warning: the following files are missing in your kit: META.yml Please inform the author. Creating new 'Build' script for 'Module-Build' version '0.18_04' [X:\home\Administrator\projects\Module-Build] $ perl Build lib/Module/Build/Platform/darwin.pm -> blib\lib/Module/Build/Platform/darwin.pm lib/Module/Build/Base.pm -> blib\lib/Module/Build/Base.pm lib/Module/Build/Platform/VMS.pm -> blib\lib/Module/Build/Platform/VMS.pm lib/Module/Build/Platform/EBCDIC.pm -> blib\lib/Module/Build/Platform/EBCDIC.pm lib/Module/Build/Platform/Amiga.pm -> blib\lib/Module/Build/Platform/Amiga.pm lib/Module/Build/PPMMaker.pm -> blib\lib/Module/Build/PPMMaker.pm lib/Module/Build/Cookbook.pm -> blib\lib/Module/Build/Cookbook.pm lib/Module/Build/Platform/Windows.pm -> blib\lib/Module/Build/Platform/Windows.pm lib/Module/Build/Platform/MPEiX.pm -> blib\lib/Module/Build/Platform/MPEiX.pm lib/Module/Build/Platform/Unix.pm -> blib\lib/Module/Build/Platform/Unix.pm lib/Module/Build/Compat.pm -> blib\lib/Module/Build/Compat.pm lib/Module/Build/Platform/MacOS.pm -> blib\lib/Module/Build/Platform/MacOS.pm lib/Module/Build/Platform/VOS.pm -> blib\lib/Module/Build/Platform/VOS.pm lib/Module/Build/Platform/RiscOS.pm -> blib\lib/Module/Build/Platform/RiscOS.pm lib/Module/Build.pm -> blib\lib/Module/Build.pm lib/Module/Build/Platform/Default.pm -> blib\lib/Module/Build/Platform/Default.pm [X:\home\Administrator\projects\Module-Build] $ perl Build test t/basic.........ok t/compat........ok 4/23 Microsoft (R) Program Maintenance Utility Version 6.00.8168.0 Copyright (C) Microsoft Corp 1988-1998. All rights reserved. t/compat........ok 5/23 Microsoft (R) Program Maintenance Utility Version 6.00.8168.0 Copyright (C) Microsoft Corp 1988-1998. All rights reserved. t/compat........ok 7/23 Microsoft (R) Program Maintenance Utility Version 6.00.8168.0 Copyright (C) Microsoft Corp 1988-1998. All rights reserved. t/compat........ok 11/23 Microsoft (R) Program Maintenance Utility Version 6.00.8168.0 Copyright (C) Microsoft Corp 1988-1998. All rights reserved. t/compat........ok 12/23 Microsoft (R) Program Maintenance Utility Version 6.00.8168.0 Copyright (C) Microsoft Corp 1988-1998. All rights reserved. t/compat........ok 14/23 Microsoft (R) Program Maintenance Utility Version 6.00.8168.0 Copyright (C) Microsoft Corp 1988-1998. All rights reserved. t/compat........ok 18/23 Microsoft (R) Program Maintenance Utility Version 6.00.8168.0 Copyright (C) Microsoft Corp 1988-1998. All rights reserved. t/compat........ok 19/23 Microsoft (R) Program Maintenance Utility Version 6.00.8168.0 Copyright (C) Microsoft Corp 1988-1998. All rights reserved. t/compat........ok 21/23 Microsoft (R) Program Maintenance Utility Version 6.00.8168.0 Copyright (C) Microsoft Corp 1988-1998. All rights reserved. t/compat........ok t/install.......ok t/runthrough....ok t/signature..... You need a passphrase to unlock the secret key for user: "Randy W. Sims <Ra...@Th...>" 1024-bit DSA key, ID D8681C21, created 2003-02-27 ==> SIGNATURE file created successfully. <== t/signature.....ok t/xs............ok All tests successful. Files=6, Tests=87, 79 wallclock secs ( 0.00 cusr + 0.00 csys = 0.00 CPU) BTW, the annoying output from make can be eleminated with the '-nologo' switch to nmake (if $Config{make} eq 'nmake'). Regards, Randy. |
|
From: Ken W. <ke...@ma...> - 2003-07-09 15:56:20
|
On Tuesday, July 8, 2003, at 09:07 PM, Randy W. Sims wrote:
>
> All clear...
Great, thanks for testing it.
> BTW, the annoying output from make can be eleminated with the
> '-nologo' switch to nmake (if $Config{make} eq 'nmake').
Okay, I'll apply the patch below.
-Ken
==========================================================
--- t/compat.t 10 Jun 2003 15:43:41 -0000 1.4
+++ t/compat.t 9 Jul 2003 15:53:51 -0000
@@ -10,6 +10,7 @@
plan tests => 23;
ok(1); # Loaded
+my @make = $Config{make} eq 'nmake' ? ('nmake', '-nologo') :
($Config{make});
my $goto = File::Spec->catdir( Module::Build->cwd, 't', 'Sample' );
chdir $goto or die "can't chdir to $goto: $!";
@@ -29,17 +30,17 @@
ok $result;
ok -e 'Makefile', 1, "Makefile exists";
- ok $build->do_system($Config{make});
+ ok $build->do_system(@make);
# Can't let 'test' STDOUT go to our STDOUT, or it'll confuse
Test::Harness.
my $success;
my $output = stdout_of( sub {
- $success = $build->do_system($Config{make},
'test');
+ $success = $build->do_system(@make, 'test');
} );
ok $success;
ok uc $output, qr{DONE\.|SUCCESS};
- ok $build->do_system($Config{make}, 'realclean');
+ ok $build->do_system(@make, 'realclean');
$build->dispatch('realclean');
ok not -e 'Makefile.PL';
}
==========================================================
|
|
From: Randy W. S. <Ra...@Th...> - 2003-07-09 23:58:41
|
On 7/9/2003 11:56 AM, Ken Williams wrote:
> Okay, I'll apply the patch below.
>
[patch snipped]
Your patch applied and ran successfully.
perl Build test
t/basic.........ok
t/compat........ok
t/install.......ok
t/runthrough....ok
t/signature.....
You need a passphrase to unlock the secret key for
user: "Randy W. Sims <Ra...@Th...>"
1024-bit DSA key, ID D8681C21, created 2003-02-27
==> SIGNATURE file created successfully. <==
t/signature.....ok
t/xs............ok
All tests successful.
Files=6, Tests=87, 88 wallclock secs ( 0.00 cusr + 0.00 csys = 0.00 CPU)
Thanks,
Randy.
--
A little learning is a dang'rous thing;
Drink deep, or taste not the Pierian spring;
There shallow draughts intoxicate the brain;
And drinking largely sobers us again.
- Alexander Pope
|
Thanks for helping keep SourceForge clean.
X