module-build-general

[Module-build-general] Cross-platform fixes for pass-through Makefile

[Ken W. <ke...@ma...>]

Hi,

After some discussions with James Freeman, I've just checked in the 
following code that generates the pass-through Makefile:

sub fake_makefile {
   my $makefile = $_[1];
   my $build = File::Spec->catfile( '.', 'Build' );

   return <<"EOF";
all :
	$build
realclean :
	$build realclean
	$^X -e unlink -e shift $makefile
.DEFAULT :
	$build \$@
.PHONY   : install manifest
EOF
}

It works fine for me, and it doesn't have any possibility of non-safe 
shell characters anymore.  Can someone test it (cvs update; perl 
Makefile.PL; make test; make realclean) on other platforms besides OS 
X?  I'm particularly keen to know whether the 'realclean' target 
succeeds in unlinking the Makefile on Win32, or whether it's considered 
"open" and can't be deleted.  If that's the case, I'll need a chmod() 
or something before unlinking.


  -Ken

Re: [Module-build-general] Cross-platform fixes for pass-through Makefile

[Dave R. <au...@ur...>]

On Mon, 17 Feb 2003, Ken Williams wrote:

> Hi,
>
> After some discussions with James Freeman, I've just checked in the
> following code that generates the pass-through Makefile:
>
> sub fake_makefile {
>    my $makefile = $_[1];
>    my $build = File::Spec->catfile( '.', 'Build' );
>
>    return <<"EOF";
> all :
> 	$build
> realclean :
> 	$build realclean
> 	$^X -e unlink -e shift $makefile

 unlink -e ???


-dave

/*=======================
House Absolute Consulting
www.houseabsolute.com
=======================*/

Re: [Module-build-general] Cross-platform fixes for pass-through Makefile

[<sc...@po...>]

On Mon, Feb 17, 2003 at 12:18:00PM -0600, Dave Rolsky wrote:
> > 	$^X -e unlink -e shift $makefile
> 
>  unlink -e ???

He's avoiding using quotes.  You're allowed to have multiple -e's on the
command line.  They'll be joined with a space and run as a single program.

Re: [Module-build-general] Cross-platform fixes for pass-through Makefile

[Ken W. <ke...@ma...>]

On Monday, February 17, 2003, at 01:17  PM, sc...@po... wrote:

> On Mon, Feb 17, 2003 at 12:18:00PM -0600, Dave Rolsky wrote:
>>> 	$^X -e unlink -e shift $makefile
>>
>>  unlink -e ???
>
> He's avoiding using quotes.  You're allowed to have multiple -e's on 
> the
> command line.  They'll be joined with a space and run as a single 
> program.

Right.  So this is just a more cross-platform way to do

	$^X -e "unlink shift" $makefile

The only part of it that's still an issue, I think, is the $^X 
variable.  It might contain something like "/My Computer/foo/bar/perl", 
in which case I guess the shell invocation would think the command was 
"/My" with argument "Computer/foo/bar/perl".

  -Ken

Re: [Module-build-general] Cross-platform fixes for pass-through Makefile

[<sc...@po...>]

On Mon, Feb 17, 2003 at 03:20:27PM -0600, Ken Williams wrote:
> Right.  So this is just a more cross-platform way to do
> 
> 	$^X -e "unlink shift" $makefile

Double quotes are surprsingly cross platform.  Just have to watch out
for Unix interpolation.


> The only part of it that's still an issue, I think, is the $^X 
> variable.  It might contain something like "/My Computer/foo/bar/perl", 
> in which case I guess the shell invocation would think the command was 
> "/My" with argument "Computer/foo/bar/perl".

Heh.  Good luck.  I gave up on that.  nmake is particularly frustrating
and brain dead about having any sane quoting rules for it.

My attempt at a cross-platform perl one-liner generating tool is:
ExtUtils::MM_Any->oneliner in 6.06_02.  I mostly gave up on trying
to deal with paths to perl with spaces in it.

Re: [Module-build-general] Cross-platform fixes for pass-through Makefile

[Ken W. <ke...@ma...>]

On Monday, February 17, 2003, at 03:55  PM, sc...@po... wrote:
> Heh.  Good luck.  I gave up on that.  nmake is particularly frustrating
> and brain dead about having any sane quoting rules for it.
>
> My attempt at a cross-platform perl one-liner generating tool is:
> ExtUtils::MM_Any->oneliner in 6.06_02.  I mostly gave up on trying
> to deal with paths to perl with spaces in it.

Good to know. =)  I'll probably punt on this issue for now, just 
because anyone with spaces in their perl pathname probably installed 
perl in a nonstandard place and will likely know how to deal with it 
(which will probably just be to use the Build.PL instead of the 
Makefile.PL, honestly, since M::B doesn't have this problem).

  -Ken