Update of /cvsroot/module-build/Module-Build/lib/Module/Build
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv20042/lib/Module/Build
Modified Files:
Notes.pm
Log Message:
Fix undef vs 0 vs '' in notes()
Index: Notes.pm
===================================================================
RCS file: /cvsroot/module-build/Module-Build/lib/Module/Build/Notes.pm,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -d -r1.11 -r1.12
--- Notes.pm 30 Jan 2006 23:14:25 -0000 1.11
+++ Notes.pm 2 Feb 2006 01:49:21 -0000 1.12
@@ -67,6 +67,13 @@
return wantarray ? %$out : $out;
}
+sub _same {
+ my ($self, $x, $y) = @_;
+ return 1 if !defined($x) and !defined($y);
+ return 0 if !defined($x) or !defined($y);
+ return $x eq $y;
+}
+
sub write {
my ($self, $href) = @_;
$href ||= {};
@@ -77,7 +84,7 @@
foreach my $key (keys %{ $self->{new} }) {
next if ref $self->{new}{$key};
next if ref $self->{disk}{$key} or !exists $self->{disk}{$key};
- delete $self->{new}{$key} if ($self->{new}{$key}||'') eq ($self->{disk}{$key}||'');
+ delete $self->{new}{$key} if $self->_same($self->{new}{$key}, $self->{disk}{$key});
}
if (my $file = $self->{file}) {
|
