module-build-checkins Mailing List for Module::Build (Page 7)
Status: Beta
Brought to you by:
kwilliams
Menu
▾
▴
module-build-checkins — Notification of CVS commits
You can subscribe to this list here.
| 2004 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
(82) |
Dec
(58) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2005 |
Jan
(49) |
Feb
(57) |
Mar
(49) |
Apr
(49) |
May
(2) |
Jun
(147) |
Jul
(60) |
Aug
(55) |
Sep
(51) |
Oct
(68) |
Nov
(61) |
Dec
(44) |
| 2006 |
Jan
(27) |
Feb
(38) |
Mar
(89) |
Apr
(31) |
May
(17) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: Randy W. S. <si...@us...> - 2006-02-21 09:26:45
|
Update of /cvsroot/module-build/ExtUtils-CBuilder In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv2354 Modified Files: Changes Log Message: Fix quoting of command line arguments on Windows. Index: Changes =================================================================== RCS file: /cvsroot/module-build/ExtUtils-CBuilder/Changes,v retrieving revision 1.46 retrieving revision 1.47 diff -u -d -r1.46 -r1.47 --- Changes 27 Dec 2005 21:42:14 -0000 1.46 +++ Changes 21 Feb 2006 09:26:35 -0000 1.47 @@ -2,6 +2,9 @@ 0.16 + - Fix quoting of command line arguments on Windows. [Yitzchak + Scott-Thoennes] + - Documented the existing 'quiet' parameter, which silences the printing of system() commands. [Suggested by Yitzchak Scott-Thoennes] |
|
From: Randy W. S. <si...@us...> - 2006-02-21 09:26:45
|
Update of /cvsroot/module-build/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv2354/lib/ExtUtils/CBuilder/Platform Modified Files: Windows.pm Log Message: Fix quoting of command line arguments on Windows. Index: Windows.pm =================================================================== RCS file: /cvsroot/module-build/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows.pm,v retrieving revision 1.11 retrieving revision 1.12 diff -u -d -r1.11 -r1.12 --- Windows.pm 3 Oct 2005 22:05:14 -0000 1.11 +++ Windows.pm 21 Feb 2006 09:26:36 -0000 1.12 @@ -93,7 +93,7 @@ sub arg_defines { my ($self, %args) = @_; s/"/\\"/g foreach values %args; - return map "-D$_=$args{$_}", keys %args; + return map qq{"-D$_=$args{$_}"}, keys %args; } sub compile { |
|
From: Randy W. S. <si...@us...> - 2006-02-21 09:15:52
|
Update of /cvsroot/module-build/Module-Build/t In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv29412/t Modified Files: moduleinfo.t Log Message: Add regression test for detecting $VERSION assignments. Index: moduleinfo.t =================================================================== RCS file: /cvsroot/module-build/Module-Build/t/moduleinfo.t,v retrieving revision 1.16 retrieving revision 1.17 diff -u -d -r1.16 -r1.17 --- moduleinfo.t 9 Jan 2006 01:18:15 -0000 1.16 +++ moduleinfo.t 21 Feb 2006 09:15:47 -0000 1.17 @@ -2,7 +2,7 @@ use strict; use lib $ENV{PERL_CORE} ? '../lib/Module/Build/t/lib' : 't/lib'; -use MBTest tests => 64; +use MBTest tests => 66; use Cwd (); my $cwd = Cwd::cwd; @@ -104,6 +104,13 @@ # whatever } --- + <<'---', # $VERSION checked only in assignments, not regexp ops +package Simple; +$VERSION = '1.23'; +if ( $VERSION =~ /1\.23/ ) { + # whatever +} +--- <<'---', # $VERSION checked only in assignments, not relational ops package Simple; $VERSION = '1.23'; |
|
From: Randy W. S. <si...@us...> - 2006-02-21 09:06:16
|
Update of /cvsroot/module-build/Module-Build In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv24426 Modified Files: Changes Log Message: Fix detection of $VERSION expressions that are not assignments. Index: Changes =================================================================== RCS file: /cvsroot/module-build/Module-Build/Changes,v retrieving revision 1.423 retrieving revision 1.424 diff -u -d -r1.423 -r1.424 --- Changes 21 Feb 2006 02:22:56 -0000 1.423 +++ Changes 21 Feb 2006 09:06:11 -0000 1.424 @@ -2,6 +2,9 @@ 0.27_08 + - Fix detection of $VERSION expressions that are not + assignments. [Spotted by Chris Dolan] + - On Windows, remove the pl2bat generated 'Build.bat' script without the annoying "The batch file cannot be found." error. [Solution provided by RazTK and foxidrive on newsgroup alt.msdos.batch] |
|
From: Randy W. S. <si...@us...> - 2006-02-21 09:06:15
|
Update of /cvsroot/module-build/Module-Build/lib/Module/Build In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv24426/lib/Module/Build Modified Files: ModuleInfo.pm Log Message: Fix detection of $VERSION expressions that are not assignments. Index: ModuleInfo.pm =================================================================== RCS file: /cvsroot/module-build/Module-Build/lib/Module/Build/ModuleInfo.pm,v retrieving revision 1.17 retrieving revision 1.18 diff -u -d -r1.17 -r1.18 --- ModuleInfo.pm 3 Feb 2006 04:20:07 -0000 1.17 +++ ModuleInfo.pm 21 Feb 2006 09:06:12 -0000 1.18 @@ -37,7 +37,7 @@ $VARNAME_REGEXP # without parens ) \s* - =[^=] # = but not == + =[^=~] # = but not ==, nor =~ /x; |
|
From: Randy W. S. <si...@us...> - 2006-02-21 02:23:04
|
Update of /cvsroot/module-build/Module-Build/lib/Module/Build/Platform In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv24242/lib/Module/Build/Platform Modified Files: Windows.pm Log Message: On Windows, remove the pl2bat generated 'Build.bat' script without the annoying "The batch file cannot be found." error. Index: Windows.pm =================================================================== RCS file: /cvsroot/module-build/Module-Build/lib/Module/Build/Platform/Windows.pm,v retrieving revision 1.28 retrieving revision 1.29 diff -u -d -r1.28 -r1.29 --- Windows.pm 17 Feb 2006 03:11:47 -0000 1.28 +++ Windows.pm 21 Feb 2006 02:22:56 -0000 1.29 @@ -4,6 +4,7 @@ use File::Basename; use File::Spec; +use IO::File; use Module::Build::Base; @@ -56,30 +57,16 @@ my $pl2bat = $self->{config}{pl2bat}; if ( defined($pl2bat) && length($pl2bat) ) { - my $ext= '.bat'; - foreach my $script (@_) { - (my $script_bat = $script) =~ s/\.plx?//i; + next if $script =~ /\.(bat|cmd)$/i; # already a script; nothing to do - if ($script_bat =~ /\.(bat|cmd)$/i) { - warn "Won't convert '$script' to a batch file named '$script_bat' nor to '$script_bat$ext'.\n"; - next; - } - $script_bat .= $ext; - $self->add_to_cleanup($script_bat); - my $status = $self->do_system("$self->{properties}{perl} $pl2bat < $script > $script_bat"); + (my $script_bat = $script) =~ s/\.plx?$//i; + $script_bat .= '.bat'; # MSWin32 executable batch script file extension - if ( $status && -f $script_bat ) { - if ( $script eq $self->{properties}{build_script} ) { - open my $fh, ">>", $script_bat or - die "Failed to open for append batch file '$script':$!"; - print $fh "\nif exist Build_FollowUp$ext Build_FollowUp$ext\n"; - close $fh; - } - $self->SUPER::make_executable($script_bat); - } else { - warn "Unable to convert '$script' to an executable.\n"; - } +# $self->add_to_cleanup($script_bat); # don't do this for $script_bat since it unlinks itself + local $self->{properties}{quiet} = 1 if $self->build_script; # Psst, keep this quiet + my $status = $self->do_system("$self->{properties}{perl} $pl2bat < $script > $script_bat"); + $self->SUPER::make_executable($script_bat); } } else { warn "Could not find 'pl2bat.bat' utility needed to make scripts executable.\n" @@ -87,6 +74,25 @@ } } +sub ACTION_realclean { + my ($self) = @_; + $self->depends_on('clean'); + + my $basename = basename($0); + $basename =~ s/(?:\.bat)?$//i; + + if ( $basename eq $self->build_script ) { + my $full_progname = $0; + $full_progname =~ s/(?:\.bat)?$/.bat/i; + + my $fh = IO::File->new(">> $basename.bat") or die "Can't create $basename.bat: $!"; + print $fh qq(start "" /min "\%comspec\%" /c del "$full_progname"); # should work for NT variants, possibly 9x + close $fh ; + + } + + $self->delete_filetree($self->config_dir, $self->build_script); +} sub manpage_separator { return '.'; |
|
From: Randy W. S. <si...@us...> - 2006-02-21 02:23:04
|
Update of /cvsroot/module-build/Module-Build/lib/Module/Build In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv24242/lib/Module/Build Modified Files: Base.pm Log Message: On Windows, remove the pl2bat generated 'Build.bat' script without the annoying "The batch file cannot be found." error. Index: Base.pm =================================================================== RCS file: /cvsroot/module-build/Module-Build/lib/Module/Build/Base.pm,v retrieving revision 1.546 retrieving revision 1.547 diff -u -d -r1.546 -r1.547 --- Base.pm 16 Feb 2006 04:32:07 -0000 1.546 +++ Base.pm 21 Feb 2006 02:22:56 -0000 1.547 @@ -1167,14 +1167,12 @@ my $closedata=""; my %q = map {$_, $self->$_()} qw(config_dir base_dir); - if ( $^O eq 'MSWin32' ) { - $q{base_dir} = Win32::GetShortPathName($q{base_dir}); - $closedata="\nclose(*DATA) unless eof(*DATA);" - ."# Necessary on Win32 to allow realclean!\n"; - } + my $case_tolerant = 0+(File::Spec->can('case_tolerant') && File::Spec->case_tolerant); $q{base_dir} = uc $q{base_dir} if $case_tolerant; + $q{base_dir} = Win32::GetShortPathName($q{base_dir}) if $^O eq 'MSWin32'; + $q{magic_numfile} = $self->config_file('magicnum'); my @myINC = $self->_added_to_INC; @@ -1204,7 +1202,6 @@ return \$filenum == $magic_number; } -$closedata my \$progname; my \$orig_dir; BEGIN { @@ -1226,6 +1223,8 @@ ); } +close(*DATA) unless eof(*DATA); # ensure no open handles to this script + use $build_package; # Some platforms have problems setting \$^X in shebang contexts, fix it up here |
|
From: Randy W. S. <si...@us...> - 2006-02-21 02:23:04
|
Update of /cvsroot/module-build/Module-Build In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv24242 Modified Files: Changes Log Message: On Windows, remove the pl2bat generated 'Build.bat' script without the annoying "The batch file cannot be found." error. Index: Changes =================================================================== RCS file: /cvsroot/module-build/Module-Build/Changes,v retrieving revision 1.422 retrieving revision 1.423 diff -u -d -r1.422 -r1.423 --- Changes 16 Feb 2006 16:34:02 -0000 1.422 +++ Changes 21 Feb 2006 02:22:56 -0000 1.423 @@ -2,6 +2,10 @@ 0.27_08 + - On Windows, remove the pl2bat generated 'Build.bat' script without + the annoying "The batch file cannot be found." error. [Solution + provided by RazTK and foxidrive on newsgroup alt.msdos.batch] + - Our version comparisons should now work correctly with modules that use version.pm to delcare their versions (e.g. "our $VERSION = version->new('1.0.0')"). [John Peacock and Ron Savage] |
|
From: Ken W. <kwi...@us...> - 2006-02-17 03:11:51
|
Update of /cvsroot/module-build/Module-Build/lib/Module/Build/Platform In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv18458/lib/Module/Build/Platform Modified Files: Windows.pm Log Message: Only add .bat suffixes when doing make_executable, not .cmd Index: Windows.pm =================================================================== RCS file: /cvsroot/module-build/Module-Build/lib/Module/Build/Platform/Windows.pm,v retrieving revision 1.27 retrieving revision 1.28 diff -u -d -r1.27 -r1.28 --- Windows.pm 16 Feb 2006 04:32:08 -0000 1.27 +++ Windows.pm 17 Feb 2006 03:11:47 -0000 1.28 @@ -56,7 +56,7 @@ my $pl2bat = $self->{config}{pl2bat}; if ( defined($pl2bat) && length($pl2bat) ) { - my $ext= $ENV{PATHEXT}=~/\.CMD(\W|$)/i ? '.cmd' : '.bat'; + my $ext= '.bat'; foreach my $script (@_) { (my $script_bat = $script) =~ s/\.plx?//i; |
|
From: Ken W. <kwi...@us...> - 2006-02-16 16:34:10
|
Update of /cvsroot/module-build/Module-Build In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv5472 Modified Files: Changes INSTALL Log Message: Suggest perl -V:make Index: Changes =================================================================== RCS file: /cvsroot/module-build/Module-Build/Changes,v retrieving revision 1.421 retrieving revision 1.422 diff -u -d -r1.421 -r1.422 --- Changes 16 Feb 2006 04:32:07 -0000 1.421 +++ Changes 16 Feb 2006 16:34:02 -0000 1.422 @@ -9,6 +9,10 @@ - We now create a Build.bat script on versions of Windows where it makes sense. [Yves] + - Fixed the verbiage around choosing the correct make-alike on + different platforms to suggest using 'perl -V:make'. [Suggested by + anonymous user] + 0.27_07 Wed Feb 1 20:07:45 CST 2006 - The notes() method now returns the new value when called with two Index: INSTALL =================================================================== RCS file: /cvsroot/module-build/Module-Build/INSTALL,v retrieving revision 1.5 retrieving revision 1.6 diff -u -d -r1.5 -r1.6 --- INSTALL 11 Jan 2004 04:14:50 -0000 1.5 +++ INSTALL 16 Feb 2006 16:34:02 -0000 1.6 @@ -22,8 +22,9 @@ make test make install (this step may need to be done as the superuser) -Substitute "nmake" or "gmake" for "make" if you prefer using some -other make-alike on your platform. +Substitute "nmake" or "gmake" for "make" if you use some other +make-alike on your platform - 'perl -V:make' can tell you what you +should use. I recommend using the Build.PL option. If you use the Makefile.PL option, you'll actually be using the Build.PL option under the surface |
|
From: Ken W. <kwi...@us...> - 2006-02-16 04:32:19
|
Update of /cvsroot/module-build/Module-Build/lib/Module/Build In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv24444/lib/Module/Build Modified Files: Base.pm Log Message: Create Build.bat Index: Base.pm =================================================================== RCS file: /cvsroot/module-build/Module-Build/lib/Module/Build/Base.pm,v retrieving revision 1.545 retrieving revision 1.546 diff -u -d -r1.545 -r1.546 --- Base.pm 2 Feb 2006 01:54:01 -0000 1.545 +++ Base.pm 16 Feb 2006 04:32:07 -0000 1.546 @@ -849,7 +849,8 @@ sub read_config { my ($self) = @_; - my $file = $self->config_file('build_params'); + my $file = $self->config_file('build_params') + or die "No build_params?"; my $fh = IO::File->new($file) or die "Can't read '$file': $!"; my $ref = eval do {local $/; <$fh>}; die if $@; @@ -1163,8 +1164,14 @@ my $build_package = $self->build_class; + my $closedata=""; + my %q = map {$_, $self->$_()} qw(config_dir base_dir); - $q{base_dir} = Win32::GetShortPathName($q{base_dir}) if $^O eq 'MSWin32'; + if ( $^O eq 'MSWin32' ) { + $q{base_dir} = Win32::GetShortPathName($q{base_dir}); + $closedata="\nclose(*DATA) unless eof(*DATA);" + ."# Necessary on Win32 to allow realclean!\n"; + } my $case_tolerant = 0+(File::Spec->can('case_tolerant') && File::Spec->case_tolerant); $q{base_dir} = uc $q{base_dir} if $case_tolerant; @@ -1197,6 +1204,7 @@ return \$filenum == $magic_number; } +$closedata my \$progname; my \$orig_dir; BEGIN { |
|
From: Ken W. <kwi...@us...> - 2006-02-16 04:32:19
|
Update of /cvsroot/module-build/Module-Build/lib/Module/Build/Platform In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv24444/lib/Module/Build/Platform Modified Files: Windows.pm Log Message: Create Build.bat Index: Windows.pm =================================================================== RCS file: /cvsroot/module-build/Module-Build/lib/Module/Build/Platform/Windows.pm,v retrieving revision 1.26 retrieving revision 1.27 diff -u -d -r1.26 -r1.27 --- Windows.pm 21 Jan 2006 18:05:01 -0000 1.26 +++ Windows.pm 16 Feb 2006 04:32:08 -0000 1.27 @@ -56,17 +56,26 @@ my $pl2bat = $self->{config}{pl2bat}; if ( defined($pl2bat) && length($pl2bat) ) { + my $ext= $ENV{PATHEXT}=~/\.CMD(\W|$)/i ? '.cmd' : '.bat'; + foreach my $script (@_) { - # Don't run 'pl2bat.bat' for the 'Build' script; - # there is no easy way to get the resulting 'Build.bat' - # to delete itself when doing a 'Build realclean'. - next if ( $script eq $self->{properties}{build_script} ); - (my $script_bat = $script) =~ s/\.plx?//i; - $script_bat .= '.bat' unless $script_bat =~ /\.bat$/i; + if ($script_bat =~ /\.(bat|cmd)$/i) { + warn "Won't convert '$script' to a batch file named '$script_bat' nor to '$script_bat$ext'.\n"; + next; + } + $script_bat .= $ext; + $self->add_to_cleanup($script_bat); my $status = $self->do_system("$self->{properties}{perl} $pl2bat < $script > $script_bat"); + if ( $status && -f $script_bat ) { + if ( $script eq $self->{properties}{build_script} ) { + open my $fh, ">>", $script_bat or + die "Failed to open for append batch file '$script':$!"; + print $fh "\nif exist Build_FollowUp$ext Build_FollowUp$ext\n"; + close $fh; + } $self->SUPER::make_executable($script_bat); } else { warn "Unable to convert '$script' to an executable.\n"; |
|
From: Ken W. <kwi...@us...> - 2006-02-16 04:32:16
|
Update of /cvsroot/module-build/Module-Build In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv24444 Modified Files: Changes Log Message: Create Build.bat Index: Changes =================================================================== RCS file: /cvsroot/module-build/Module-Build/Changes,v retrieving revision 1.420 retrieving revision 1.421 diff -u -d -r1.420 -r1.421 --- Changes 3 Feb 2006 04:20:03 -0000 1.420 +++ Changes 16 Feb 2006 04:32:07 -0000 1.421 @@ -6,6 +6,9 @@ use version.pm to delcare their versions (e.g. "our $VERSION = version->new('1.0.0')"). [John Peacock and Ron Savage] + - We now create a Build.bat script on versions of Windows where it + makes sense. [Yves] + 0.27_07 Wed Feb 1 20:07:45 CST 2006 - The notes() method now returns the new value when called with two |
|
From: Ken W. <kwi...@us...> - 2006-02-16 04:07:06
|
Update of /cvsroot/module-build/Module-Build/t In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv17414/t Modified Files: runthrough.t Log Message: Use a numeric comparison for versions Index: runthrough.t =================================================================== RCS file: /cvsroot/module-build/Module-Build/t/runthrough.t,v retrieving revision 1.64 retrieving revision 1.65 diff -u -d -r1.64 -r1.65 --- runthrough.t 9 Jan 2006 03:58:01 -0000 1.64 +++ runthrough.t 16 Feb 2006 04:06:58 -0000 1.65 @@ -139,7 +139,7 @@ my $fh = IO::File->new(File::Spec->catfile($dist->dirname, 'META.yml')); my $contents = do {local $/; <$fh>}; $contents =~ /Module::Build version ([0-9_.]+)/m; - is $1, $mb->VERSION, "Check version used to create META.yml: $1 == " . $mb->VERSION; + cmp_ok $1, '==', $mb->VERSION, "Check version used to create META.yml: $1 == " . $mb->VERSION; SKIP: { skip( "not sure if we can create a tarball on this platform", 1 ) |
|
From: Ken W. <kwi...@us...> - 2006-02-03 04:20:20
|
Update of /cvsroot/module-build/Module-Build/lib/Module/Build In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv14399/lib/Module/Build Modified Files: ModuleInfo.pm Log Message: version.pm-related fix Index: ModuleInfo.pm =================================================================== RCS file: /cvsroot/module-build/Module-Build/lib/Module/Build/ModuleInfo.pm,v retrieving revision 1.16 retrieving revision 1.17 diff -u -d -r1.16 -r1.17 --- ModuleInfo.pm 3 Dec 2005 03:08:14 -0000 1.16 +++ ModuleInfo.pm 3 Feb 2006 04:20:07 -0000 1.17 @@ -299,7 +299,7 @@ warn "Error evaling version line '$eval' in $self->{filename}: $@\n" if $@; # Unbless it if it's a version.pm object - $result = "$result" if UNIVERSAL::isa( $result, 'version' ); + $result = $result->numify if UNIVERSAL::isa($result, 'version'); return $result; } |
|
From: Ken W. <kwi...@us...> - 2006-02-03 04:20:20
|
Update of /cvsroot/module-build/Module-Build In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv14399 Modified Files: Changes Log Message: version.pm-related fix Index: Changes =================================================================== RCS file: /cvsroot/module-build/Module-Build/Changes,v retrieving revision 1.419 retrieving revision 1.420 diff -u -d -r1.419 -r1.420 --- Changes 2 Feb 2006 02:11:19 -0000 1.419 +++ Changes 3 Feb 2006 04:20:03 -0000 1.420 @@ -1,5 +1,11 @@ Revision history for Perl extension Module::Build. +0.27_08 + + - Our version comparisons should now work correctly with modules that + use version.pm to delcare their versions (e.g. "our $VERSION = + version->new('1.0.0')"). [John Peacock and Ron Savage] + 0.27_07 Wed Feb 1 20:07:45 CST 2006 - The notes() method now returns the new value when called with two |
|
From: Ken W. <kwi...@us...> - 2006-02-02 02:11:30
|
Update of /cvsroot/module-build/Module-Build/lib/Module In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv27638/lib/Module Modified Files: Build.pm Log Message: Version bump Index: Build.pm =================================================================== RCS file: /cvsroot/module-build/Module-Build/lib/Module/Build.pm,v retrieving revision 1.208 retrieving revision 1.209 diff -u -d -r1.208 -r1.209 --- Build.pm 24 Jan 2006 03:45:08 -0000 1.208 +++ Build.pm 2 Feb 2006 02:11:19 -0000 1.209 @@ -15,7 +15,7 @@ use vars qw($VERSION @ISA); @ISA = qw(Module::Build::Base); -$VERSION = '0.27_06'; +$VERSION = '0.27_07'; $VERSION = eval $VERSION; # Okay, this is the brute-force method of finding out what kind of |
|
From: Ken W. <kwi...@us...> - 2006-02-02 02:11:29
|
Update of /cvsroot/module-build/Module-Build In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv27638 Modified Files: Changes Log Message: Version bump Index: Changes =================================================================== RCS file: /cvsroot/module-build/Module-Build/Changes,v retrieving revision 1.418 retrieving revision 1.419 diff -u -d -r1.418 -r1.419 --- Changes 2 Feb 2006 02:04:54 -0000 1.418 +++ Changes 2 Feb 2006 02:11:19 -0000 1.419 @@ -1,6 +1,6 @@ Revision history for Perl extension Module::Build. -0.27_07 +0.27_07 Wed Feb 1 20:07:45 CST 2006 - The notes() method now returns the new value when called with two arguments, just like when it's called with one argument. [Tyler |
|
From: Ken W. <kwi...@us...> - 2006-02-02 02:05:17
|
Update of /cvsroot/module-build/Module-Build/inc In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv25418/inc Modified Files: ModuleBuildBuilder.pm Log Message: Sign the distdir twice since we modified some files Index: ModuleBuildBuilder.pm =================================================================== RCS file: /cvsroot/module-build/Module-Build/inc/ModuleBuildBuilder.pm,v retrieving revision 1.5 retrieving revision 1.6 diff -u -d -r1.5 -r1.6 --- ModuleBuildBuilder.pm 15 Jul 2005 12:42:23 -0000 1.5 +++ ModuleBuildBuilder.pm 2 Feb 2006 02:04:54 -0000 1.6 @@ -30,6 +30,9 @@ # Module::Build object instead of a ModuleBuildBuilder. $self->do_replace(qq[BEGIN{\$/=undef} s{<remove_me>.*</remove_me>}{}gs], $build_pl); $self->do_replace(qq[s{ModuleBuildBuilder}{Module::Build}gs], $build_pl); + + # XXX Band-aid the signing here again, since we modified some files. + $self->depends_on('distsign'); } sub do_replace { |
|
From: Ken W. <kwi...@us...> - 2006-02-02 02:05:06
|
Update of /cvsroot/module-build/Module-Build In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv25418 Modified Files: Changes Log Message: Sign the distdir twice since we modified some files Index: Changes =================================================================== RCS file: /cvsroot/module-build/Module-Build/Changes,v retrieving revision 1.417 retrieving revision 1.418 diff -u -d -r1.417 -r1.418 --- Changes 2 Feb 2006 01:54:01 -0000 1.417 +++ Changes 2 Feb 2006 02:04:54 -0000 1.418 @@ -13,6 +13,11 @@ a build subclass lives, so that we're sure to pick up the right version and not some already-installed version. [perlmonkey] + - The SIGNATURE file for version 0.27_06 (and I'm sure for lots of + versions before that too!) was messed up, since we were modifying + some files after signing. This has been band-aided for the time + being by signing twice. [Reported by Chris Dolan] + 0.27_06 Mon Jan 23 21:44:54 CST 2006 - Fixed an undefined-variable warning when building the META.yml file |
|
From: Ken W. <kwi...@us...> - 2006-02-02 01:54:15
|
Update of /cvsroot/module-build/Module-Build/lib/Module/Build In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv21530/lib/Module/Build Modified Files: Base.pm Log Message: unshift(@INC) instead of push(@INC) Index: Base.pm =================================================================== RCS file: /cvsroot/module-build/Module-Build/lib/Module/Build/Base.pm,v retrieving revision 1.544 retrieving revision 1.545 diff -u -d -r1.544 -r1.545 --- Base.pm 23 Jan 2006 13:27:43 -0000 1.544 +++ Base.pm 2 Feb 2006 01:54:01 -0000 1.545 @@ -747,7 +747,7 @@ EOF close $fh; - push @INC, File::Spec->catdir(File::Spec->rel2abs($build_dir), 'lib'); + unshift @INC, File::Spec->catdir(File::Spec->rel2abs($build_dir), 'lib'); eval "use $opts{class}"; die $@ if $@; |
|
From: Ken W. <kwi...@us...> - 2006-02-02 01:54:14
|
Update of /cvsroot/module-build/Module-Build In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv21530 Modified Files: Changes Log Message: unshift(@INC) instead of push(@INC) Index: Changes =================================================================== RCS file: /cvsroot/module-build/Module-Build/Changes,v retrieving revision 1.416 retrieving revision 1.417 diff -u -d -r1.416 -r1.417 --- Changes 2 Feb 2006 01:49:21 -0000 1.416 +++ Changes 2 Feb 2006 01:54:01 -0000 1.417 @@ -9,6 +9,10 @@ - The notes() method now distinguishes among the values undef, 0, and the empty string, where previously it didn't. [Tyler MacDonald] + - We now unshift(@INC) rather than push(@INC) for the directory where + a build subclass lives, so that we're sure to pick up the right + version and not some already-installed version. [perlmonkey] + 0.27_06 Mon Jan 23 21:44:54 CST 2006 - Fixed an undefined-variable warning when building the META.yml file |
|
From: Ken W. <kwi...@us...> - 2006-02-02 01:49:32
|
Update of /cvsroot/module-build/Module-Build In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv20042 Modified Files: Changes Log Message: Fix undef vs 0 vs '' in notes() Index: Changes =================================================================== RCS file: /cvsroot/module-build/Module-Build/Changes,v retrieving revision 1.415 retrieving revision 1.416 diff -u -d -r1.415 -r1.416 --- Changes 30 Jan 2006 23:14:23 -0000 1.415 +++ Changes 2 Feb 2006 01:49:21 -0000 1.416 @@ -6,6 +6,9 @@ arguments, just like when it's called with one argument. [Tyler MacDonald] + - The notes() method now distinguishes among the values undef, 0, and + the empty string, where previously it didn't. [Tyler MacDonald] + 0.27_06 Mon Jan 23 21:44:54 CST 2006 - Fixed an undefined-variable warning when building the META.yml file |
|
From: Ken W. <kwi...@us...> - 2006-02-02 01:49:32
|
Update of /cvsroot/module-build/Module-Build/lib/Module/Build In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv20042/lib/Module/Build Modified Files: Notes.pm Log Message: Fix undef vs 0 vs '' in notes() Index: Notes.pm =================================================================== RCS file: /cvsroot/module-build/Module-Build/lib/Module/Build/Notes.pm,v retrieving revision 1.11 retrieving revision 1.12 diff -u -d -r1.11 -r1.12 --- Notes.pm 30 Jan 2006 23:14:25 -0000 1.11 +++ Notes.pm 2 Feb 2006 01:49:21 -0000 1.12 @@ -67,6 +67,13 @@ return wantarray ? %$out : $out; } +sub _same { + my ($self, $x, $y) = @_; + return 1 if !defined($x) and !defined($y); + return 0 if !defined($x) or !defined($y); + return $x eq $y; +} + sub write { my ($self, $href) = @_; $href ||= {}; @@ -77,7 +84,7 @@ foreach my $key (keys %{ $self->{new} }) { next if ref $self->{new}{$key}; next if ref $self->{disk}{$key} or !exists $self->{disk}{$key}; - delete $self->{new}{$key} if ($self->{new}{$key}||'') eq ($self->{disk}{$key}||''); + delete $self->{new}{$key} if $self->_same($self->{new}{$key}, $self->{disk}{$key}); } if (my $file = $self->{file}) { |
|
From: Ken W. <kwi...@us...> - 2006-02-02 01:49:32
|
Update of /cvsroot/module-build/Module-Build/t In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv20042/t Modified Files: notes.t Log Message: Fix undef vs 0 vs '' in notes() Index: notes.t =================================================================== RCS file: /cvsroot/module-build/Module-Build/t/notes.t,v retrieving revision 1.19 retrieving revision 1.20 diff -u -d -r1.19 -r1.20 --- notes.t 9 Jan 2006 01:18:15 -0000 1.19 +++ notes.t 2 Feb 2006 01:49:21 -0000 1.20 @@ -2,7 +2,7 @@ use strict; use lib $ENV{PERL_CORE} ? '../lib/Module/Build/t/lib' : 't/lib'; -use MBTest tests => 8; +use MBTest tests => 11; use Cwd (); my $cwd = Cwd::cwd; @@ -46,6 +46,13 @@ $mb->notes(foo => 'bar'); is $mb->notes('foo'), 'bar'; +# Check undef vs. 0 vs '' +foreach my $val (undef, 0, '') { + $mb->notes(null => $val); + is $mb->notes('null'), $val; +} + + ################################### # Make sure notes set before create_build_script() get preserved $mb = Module::Build->new(module_name => $dist->name); |
