Re: [Module::Build] Re: [Yaml-core] yaml_dump on version objects
Status: Beta
Brought to you by:
kwilliams
|
From: Ken W. <ke...@ma...> - 2006-02-16 21:03:57
|
On Feb 16, 2006, at 12:08 PM, John Peacock wrote: > Ken Williams wrote: >> On Feb 16, 2006, at 11:46 AM, John Peacock wrote: >>> Is there some overriding reason you are avoiding upgrading the YAML >>> prereq to 0.50 (which in itself isn't even the current rev)? >> Good question. I guess not, though this is the first time I think >> we'd upgrade an auto-feature dependency, and it has just occurred to >> me that it'll catch people by surprise if they currently have that >> feature enabled. It will suddenly get non-enabled without much >> warning. > > Can't the 0.28 installer test for the auto-feature already being > enabled *and* whether YAML is new enough and then upgrade that to a > mandatory prereq? Yup, it could, and it probably should. I'd just never thought of it before this thread so it doesn't do it yet, and to make things DTRT we should really think through various contingencies - such as what happens when the user has a previously-acceptable YAML installed and is willing to turn off the feature because they don't want to upgrade. I think the various cases could get tricky. I'd prefer to keep the declaration of 'auto_features' purely declarative, and have the checker implement all the necessary decisions rather than sticking functions into the declarations, though. -Ken |