Re: [Module::Build] Broken test in runthrough.t

[John P. <jpe...@ro...>]

Andreas J. Koenig wrote:
> The following test is broken in bleadperl:
> 
>   my $fh = IO::File->new(File::Spec->catfile($dist->dirname, 'META.yml'));
>   my $contents = do {local $/; <$fh>};
>   $contents =~ /Module::Build version ([0-9_.]+)/m;
>   is $1, $mb->VERSION, "Check version used to create META.yml: $1 == " . $mb->VERSION;
> 
> The last line should compensate for trailing zeroes:
> 
>   is 0+$1, 0+$mb->VERSION, "Check version used to create META.yml: $1 == " . $mb->VERSION;

Or better yet, stop doing *string* comparison with *numbers* (or $VERSION's):

> ok $1 == $mb->VERSION, "Check version used to create META.yml: $1 == " . $mb->VERSION;

Module::Build _will_ continue to break in various ways until it completely
understands version objects (a patch I'm working on in a different window).  The
reason for this is the code in Module::Build::ModuleInfo which tries to "ignore"
version.pm's UNIVERSAL::VERSION (in favor of the existing pre-bleadperl code).
Unfortunately for Module::Build, in bleadperl, there is *only* the correct
version-object-aware code...

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747