Re: [Module::Build] proposed patch for "testauthor" action

[David G. <da...@hy...>]

Yitzchak Scott-Thoennes wrote:
>> It provides a "testauthor" action that sets $ENV{AUTHOR_TESTING} to 1 
>> before running the "test" action.
> 
> I would also suggest setting it in ACTION_disttest.

Isn't disttest supposed to mimic what would happen if someone downloaded 
the distribution and ran the tests?  From that perspective, I'm not sure 
that it should run in that situation.

>> The name of the action follows the pattern set by "testdb", "testpod", 
>> "testcover", etc.  The environment variable follows the pattern of 
>> "AUTOMATED_TESTING" used by the CPAN smoke tests.
> 
> Despite the AUTOMATED_TESTING precedent, I'd prefer to see
> a PERL_ prefix on the environment variable.

I thought about that and would be supportive of it if a consensus 
emerged.  (I figured putting out a patch would force a decision.)

>> +=item testauthor
>> +
>> +This is a synonym for the C<test> action with the environment variable
>> +C<AUTHOR_TESTING> set to 1.  Test files that are only of interest to module
>> +authors during development choose to skip running if the environment variable
>> +is not set.  E.g.
> 
> That reads a little awkwardly.  Did you mean "may choose"?

Yes.  Thank you for catching that.  I kept rewording that tortured 
sentence between a recommendation and an option.  Somewhere in there, 
the "may" went away.

Regards,
David