Re: [Module::Build] proposed patch for "testauthor" action

[Yitzchak Scott-T. <sth...@ef...>]

On Sat, Feb 04, 2006 at 05:06:22PM -0500, David Golden wrote:
> Following the notion that actions speak louder than words, I offer the 
> attached patch against the current CVS head.  (Including test file and 
> documentation.)
> 
> It provides a "testauthor" action that sets $ENV{AUTHOR_TESTING} to 1 
> before running the "test" action.

I would also suggest setting it in ACTION_disttest.
 
> The name of the action follows the pattern set by "testdb", "testpod", 
> "testcover", etc.  The environment variable follows the pattern of 
> "AUTOMATED_TESTING" used by the CPAN smoke tests.

Despite the AUTOMATED_TESTING precedent, I'd prefer to see
a PERL_ prefix on the environment variable.

> +=item testauthor
> +
> +This is a synonym for the C<test> action with the environment variable
> +C<AUTHOR_TESTING> set to 1.  Test files that are only of interest to module
> +authors during development choose to skip running if the environment variable
> +is not set.  E.g.

That reads a little awkwardly.  Did you mean "may choose"?