Re: [Module::Build] version.pm and version number comparison problem

[Ken W. <ke...@ma...>]

On Feb 3, 2006, at 6:17 AM, John Peacock wrote:

> Ken Williams wrote:
>>> While we're at it, we should change the
>>>   UNIVERSAL::isa( $result, 'version' )
>>> to
>>>   eval { $result->isa('version') }
>>
>> That's probably better, but it has its own problems.  What if 
>> someone's
>> overloaded isa() object is trying to throw an exception?  This will
>> throw it away.
>
> But we aren't talking about some random class.  This *only* applies to
> version.pm and I can personally guarantee that it will never include an
> overloaded isa() method (I know the author).
>
> Just use the original patch I suggested with ->numify() and 
> UNIVERSAL::isa() and
> worry about the theoretical best practices someplace else... ;-)

Yup, that's what I've done.

  -Ken