Re: [Module::Build] version.pm and version number comparison problem
Status: Beta
Brought to you by:
kwilliams
|
From: John P. <jpe...@ro...> - 2006-02-03 12:17:19
|
Ken Williams wrote:
>> While we're at it, we should change the
>> UNIVERSAL::isa( $result, 'version' )
>> to
>> eval { $result->isa('version') }
>
> That's probably better, but it has its own problems. What if someone's
> overloaded isa() object is trying to throw an exception? This will
> throw it away.
But we aren't talking about some random class. This *only* applies to
version.pm and I can personally guarantee that it will never include an
overloaded isa() method (I know the author).
Just use the original patch I suggested with ->numify() and UNIVERSAL::isa() and
worry about the theoretical best practices someplace else... ;-)
John
--
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747
|