Re: [Module::Build] [PATCH] Write minimal META.yml unless -e YAML.pm
Status: Beta
Brought to you by:
kwilliams
|
From: Ken W. <ke...@ma...> - 2004-01-09 17:54:35
|
On Sunday, January 4, 2004, at 01:24 AM, Randy W. Sims wrote:
> On 1/4/2004 12:44 AM, Ken Williams wrote:
>> Do we want $self->{dist_author} to always be an array ref, or always
>> be however the user specified it? I'm thinking the latter, but I'm
>> not sure.
>
> I think it has to accept either. For backwards compatibility it needs
> to accept a single string, and that's what will probably be used most
> often anyway, so it's convenient. I think it should also accept an
> array reference because many projects are developed by teams, and its
> easy and makes sense to allow for that.
Yeah, I agree - my question was about what dist_author() should output,
not what it should accept as input. I've checked in a version of the
patch that accepts an arrayref or string, and outputs an arrayref, just
as yours did (I think).
You may want to take a quick look over the patches I put in today &
yesterday, to make sure I didn't make any boneheaded changes. Let me
know if so.
-Ken
|