Re: [Module::Build] [PATCH] Write minimal META.yml unless -e YAML.pm
Status: Beta
Brought to you by:
kwilliams
|
From: Randy W. S. <Ra...@Th...> - 2003-12-30 23:38:19
|
On 12/30/2003 1:37 AM, Randy W. Sims wrote:
> I'm not sure this patch is clean or complete (I'm up past my bedtime),
> but I thought I'd post for comments. This patch:
>
Looking at this again, I see I missed the return in
_write_minimal_metadata() which should be something like
return ++$self->{wrote_metadata};
That function could be named something better, maybe
_write_degenerate_metadata().
Maybe a better patch would refactor all the dist stuff into a module,
say M::B::Distribution, that would be responsible for collecting and
deducing info about the dist, producing tarballs, etc. And the metadata
stuff could be collected in M::B::Distribution::Metadata which would
handle gathering metadata for generation of META.yml and PPD files, and
would later likely become a proxy or interface to the metadata module
you mentioned.
I'll hold on that for now; I've been procrastinating on another little
problem I said I'd look into.
Regards,
Randy.
|