Re: [Module::Build] codebase? paths in .tar.gz?
Status: Beta
Brought to you by:
kwilliams
|
From: Glenn L. <pe...@ne...> - 2003-12-20 17:23:09
|
I'm no expert in the required contents of a .ppd file. But I can't
imagine ever wanting one that doesn't have a version. While it is nice
to also have the author and abstract, I can't see that having them or
not having them makes the module more or less functional.
On approximately 12/20/2003 8:23 AM, came the following characters from
the keyboard of Ken Williams:
> Hi,
>
> I applied the documentation part of the patch, but I had already patched
> the other stuff in a different way by the time I saw this. Is it not
> good to simply die() when there's no version, abstract, or author?
> Seems like those should be required.
>
> -Ken
>
>
> On Saturday, December 20, 2003, at 04:41 AM, Randy W. Sims wrote:
>
>>
>> This patch:
>>
>> * Moves documentation for the C<codebase> parameter to the section
>> describing the ppd action.
>>
>> * Set C<codebase> to default to the distribution name with a '.tar.gz'
>> extension. Notify user if the default is used.
>>
>> * Warn user to edit the produced PPD file if we can't determine values
>> for name, version, and abstract.
>>
>>
>> I will leave writing tutorials to someone with more literary talent than
>> I :-)
>>
>> Regards,
>> Randy.
>>
>>
>> diff -urN Module-Build-orig/lib/Module/Build/PPMMaker.pm
>> Module-Build/lib/Module/Build/PPMMaker.pm
>> --- Module-Build-orig/lib/Module/Build/PPMMaker.pm 2003-07-25
>> 10:15:19.000000000 -0400
>> +++ Module-Build/lib/Module/Build/PPMMaker.pm 2003-12-20
>> 04:56:36.000000000 -0500
>> @@ -15,14 +15,23 @@
>> my ($self, %args) = @_;
>> my $build = delete $args{build};
>>
>> - die "Cannot create a PPD file unless codebase argument is given\n"
>> - unless exists $args{codebase};
>> - my @codebase = ref $args{codebase} ? @{$args{codebase}} :
>> ($args{codebase});
>> + my $name = $build->dist_name || '';
>> + my $author = $build->dist_author || '';
>> + my $abstract = $build->dist_abstract || '';
>> + my $version = $self->_ppd_version($build->dist_version) || '';
>> +
>> + die "Cannot determine distribution name.\n" unless length($name);
>> +
>> + warn "Missing information for PPD. Please edit before distributing.\n"
>> + unless length($author) && length($abstract) && length($version);
>> +
>> + unless (exists $args{codebase}) {
>> + my $codebase = $build->dist_dir . '.tar.gz';
>> + $args{codebase} = $codebase;
>> + print "Using a default CODEBASE of '$codebase'\n";
>> + }
>>
>> - my $name = $build->dist_name;
>> - my $author = $build->dist_author;
>> - my $abstract = $build->dist_abstract;
>> - my $version = $self->_ppd_version($build->dist_version);
>> + my @codebase = ref $args{codebase} ? @{$args{codebase}} :
>> ($args{codebase});
>>
>> $self->_simple_xml_escape($_) foreach ($abstract, $author);
>>
>> diff -urN Module-Build-orig/lib/Module/Build.pm
>> Module-Build/lib/Module/Build.pm
>> --- Module-Build-orig/lib/Module/Build.pm 2003-12-09
>> 21:36:45.000000000 -0500
>> +++ Module-Build/lib/Module/Build.pm 2003-12-20 04:35:23.000000000
>> -0500
>> @@ -575,13 +575,6 @@
>> version. It looks for the first line matching C<$package\s-\s(.+)>,
>> and uses the captured text as the abstract.
>>
>> -=item codebase
>> -
>> -This can be either a single scalar string, or an array reference of
>> -strings. It is required when creating PPD files. It should be a URL,
>> -or URLs, to be used as the value for the C<< <CODEBASE> >> tag in the
>> -generated PPD.
>> -
>> =back
>>
>> =item subclass()
>> @@ -1212,6 +1205,15 @@
>>
>> Build a PPD file for your distribution.
>>
>> +This action takes an optional argument C<codebase> which is used in
>> +the generated ppd file to specify the (usually relative) URL of the
>> +distribution. By default, this value is the distribution name without
>> +any path information.
>> +
>> +Example:
>> +
>> + perl Build ppd
>> codebase="MSWin32-x86-multi-thread/Module-Build-0.21.tar.gz"
>> +
>> =back
>>
>> =head2 How Installation Paths are Determined
>>
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: IBM Linux Tutorials.
> Become an expert in LINUX or just sharpen your skills. Sign up for IBM's
> Free Linux Tutorials. Learn everything from the bash shell to sys admin.
> Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click
> _______________________________________________
> Module-build-general mailing list
> Mod...@li...
> https://lists.sourceforge.net/lists/listinfo/module-build-general
>
>
--
Glenn -- http://nevcal.com/
===========================
Like almost everyone, I receive a lot of spam every day, much of it
offering to help me get out of debt or get rich quick. It's ridiculous.
-- Bill Gates
And here is why it is ridiculous:
The division that includes Windows posted an operating profit of $2.26
billion on revenue of $2.81 billion.
--from Reuters via
http://biz.yahoo.com/rc/031113/tech_microsoft_msn_1.html
So that's profit of over 400% of investment... with a bit more
investment in Windows technology, particularly in the area of
reliability, the profit percentage might go down, but so might the bugs
and security problems? Seems like it would be a reasonable tradeoff.
WalMart earnings are 3.4% of investment.
|