Re: [Module::Build] create_readme =>1 doesn't cause README to be added to MANIFEST

[Sagar S. <sag...@so...>]

On Wed, 2003-12-03 at 06:31, Michael G Schwern wrote:
> On Fri, Nov 28, 2003 at 03:13:32PM -0600, Ken Williams wrote:
> > >One problem that i've found is that when generating the MANIFEST
> > >Module::Build doesn't add the README to it, and so it doesn't actually
> > >get includede in the dist tarball...
> > >
> > >Bug?
> >=20
> > I'm reluctant to add things automatically to the MANIFEST, because in=20
> > general I don't want to surprise the user about things.  With the=20
> > SIGNATURE file there's a chicken-egg problem that can only be solved by=
=20
> > adding it to the MANIFEST automatically, but with the README I think=20
> > the author should just add it him/herself.
>=20
> I dunno.  It seems that the Principle of Least Surprise would say that
> if you created a README automaticly, you'd want it distributed.  Since
> there's little indication to the author that the README is *not* getting
> distributed, I'd say the common bug will be an author that sets
> create_readme and then forgets to add it to the MANIFEST.  Not the author
> that turns on create_readme and doesn't want it in the MANIFEST.

Ken,

I agree with Michael's comments, but the use case where i hit this was
where I don't even have a MANIFEST. I just use a MANIFEST.SKIP and have
M::B create my MANIFEST for me.=20

So you see, i cannot add README to the MANIFEST because i don't have a
self made MANIFEST. create_readme doesn't cause the README to be created
before the MANIFEST is generated. So perhaps if you don't want
create_readme to explicty insert README into MANIFEST, perhaps you can
change the ordering of the actions slightly?=20

That way users who do have a MANIFEST will not get surprised by extra
additions. Whereas users with no MANIFEST, will 'get the right
manifest'.

Warming to the idea @ all?

Cheers

Sagar

--=20
Sagar Shah <sag...@so...>