Re: [Module::Build] Array form of do_system causing problems

[Chris D. <ch...@cl...>]

On Thursday, October 16, 2003, at 07:36  PM, Ken Williams wrote:

> On Thursday, October 16, 2003, at 01:40  PM, Chris Dolan wrote:
>
>> Perhaps do_system should check if there are spaces in the name of the 
>> executable?  That might not be the right thing on a Windows box, or 
>> any other platform where spaces commonly occur in directory names...
>
> Yeah, and it specifically does the wrong thing if your gzip is
> something like "/My Macintosh/My Stuff/gzip".

Hmm, I thought about putting "m{\s[^/]+$}" in the patch, but it had 
occurred to me that "perl -Iblib/lib" would be broken by that...

> The 'gzip' parameter is intended to be the path to gzip, not the path 
> plus arguments.  But if it's important to take arguments, that could 
> be added.

That makes sense.  I'm just used to Makefiles, where you can add 
cmdline args to gcc via the "make CC='gcc -Ddebug'" syntax, for example.

Anyone else have any good ideas how to handle user cmdline options 
while still maintaining the simplicity of the array version of system()?

Chris