Re: [Module::Build] M::B 0.21 OSX warnings

[Ken W. <ke...@ma...>]

On Thursday, October 16, 2003, at 10:19  AM, Chris Dolan wrote:

> I saw a bunch of warnings from 'Build test' on Mac OSX, perl 5.8.1, 
> M::B v0.21.  These occur in manifypods.t, and originate from 
> File::Spec::Unix::canonpath() getting undef and not handling it 
> properly.
>
> First, I submitted a patch to File::Spec to better handle the undef.  
> But, we really shouldn't be handing undef to canonpath in the first 
> place.
>
> I discovered the source of the undef by running:
>    perl -w -Mblib -MCarp 
> -e'$SIG{__WARN__}=\&confess;do"t/manifypods.t"'
> which showed the cause to be localize_file_path() called with '' as 
> the path.
>
> The following patch prevents localize_file_path from trying to do any 
> work if the path is already localized by virtue of being relative.
>
> Chris
>
> --- lib/Module/Build/Base.pm.orig      2003-10-16 09:29:52.000000000 
> -0500
> +++ lib/Module/Build/Base.pm    2003-10-16 10:06:32.000000000 -0500
> @@ -1221,6 +1221,7 @@
>
>  sub localize_file_path {
>    my ($self, $path) = @_;
> +  return $path unless ($path =~ m{/});
>    return File::Spec->catfile( split qr{/}, $path );
>  }
>

Looks good, I'll apply.

I didn't see this because I'm using a newer version of File::Spec, I 
guess.  What line in t/manifypods.t is causing the problem?

  -Ken