Re: [Module::Build] Array form of do_system causing problems

[Ken W. <ke...@ma...>]

On Thursday, October 16, 2003, at 01:40  PM, Chris Dolan wrote:

> I build packages like this:
>    Build dist gzip="gzip -f --best"
>
> This causes Module::Build::Platform::Unix to emit:
>    $self->do_system("gzip -f --best", "$dir.tar");
> which bombs because there is no program called "gzip -f --best".
>
> Perhaps do_system should check if there are spaces in the name of the 
> executable?  That might not be the right thing on a Windows box, or 
> any other platform where spaces commonly occur in directory names...
>
> Regardless of that complication, here's a new version of do_system.  
> It fixes the bug, but reintroduces the shell complications we were 
> trying to avoid.

Yeah, and it specifically does the wrong thing if your gzip is
something like "/My Macintosh/My Stuff/gzip".

The 'gzip' parameter is intended to be the path to gzip, not the path 
plus arguments.  But if it's important to take arguments, that could be 
added.

  -Ken