[Module::Build] Re: [Module-build-general] patch for cygwin

[Ken W. <ke...@ma...>]

Okay, I've committed this patch.  Thanks.

  -Ken

On Wednesday, September 24, 2003, at 01:06  AM, Yitzchak Scott-Thoennes 
wrote:
> Couldn't install Module::Build...the manpage names contain colons.
> Patch below fixes it.  Looking at MakeMaker, I see MM_UWIN and MM_OS2
> ($^O eq 'uwin' and 'os2', respectively) also use '.', but have no
> special code in Module::Build.  MakeMaker uses '__' for DOS,
> Module::Build uses '.' (via Platform/Windows.pm).
>
> I left os_type as Unix for cygwin.  Darwin does the same.  You might
> think about implementing an os_flavor ala MakeMaker instead (where one
> platform can list multiple types) with an os_flavor_is(@foo) routine
> checking if any of the @foo types apply.
>
> Would have been nice if install.t had caught the problem instead of
> the actual install failing midway, but the install.t only tries a
> top-level module name.
>
> t/xs.t is failing tests 4 and 8.  I'm not sure how to translate the
> other things MM_Cygwin does into Module::Build terms.