Re: [Module-build-general] patch for cygwin
Status: Beta
Brought to you by:
kwilliams
|
From: Steve P. <sp...@qu...> - 2003-09-25 09:08:00
|
On Wednesday, September 24, 2003, at 06:05 pm, Yitzchak Scott-Thoennes
wrote:
> On Wed, Sep 24, 2003 at 05:29:23PM +0100, Steve Purkis
> <sp...@qu...> wrote:
>> On Wednesday, September 24, 2003, at 07:06 am, Yitzchak
>> Scott-Thoennes
>> wrote:
>>
>>> Couldn't install Module::Build...the manpage names contain colons.
>>> Patch below fixes it. Looking at MakeMaker, I see MM_UWIN and MM_OS2
>>> ($^O eq 'uwin' and 'os2', respectively) also use '.', but have no
>>> special code in Module::Build. MakeMaker uses '__' for DOS,
>>> Module::Build uses '.' (via Platform/Windows.pm).
>>
>> Might make sense to use '__' for cygwin then, to preserve MM
>> compatibility.
>
> I assume you mean DOS, not cygwin. cygwin should use '.'.
Actually, I was a bit confused there. I meant cygwin, but then I've
just looked at MM_Cygwin, which inherits its manpage separator from
MM_Unix ('::' again), so M::B was backwards compatible to begin with.
Perhaps MM_Cygwin's manpage generation is broken?
As an aside, I always thought it would be a bit more useful to generate
HTML manpages on Win32 & friends, considering they don't have a 'man'
tool by default. I suppose cygwin supplies one, so it's not a problem
there. But there might be a case for an option that lets the user
build HTML or MAN pages.
>> I didn't see a Module::Build subclass for the others
>> you've mentioned, so I left them out of the original patch[1].
>>
>> Perhaps stubs for them should be created too?
>
> Only if someone is going to try them. I don't even know what uwin is.
Point taken.
-Steve
|