Re: [Module-build-general] [BUG] ./Build dist does not check for new $VERSION
Status: Beta
Brought to you by:
kwilliams
|
From: Steve P. <sp...@qu...> - 2003-09-15 18:03:24
|
On Monday, September 15, 2003, at 06:15 pm, Ken Williams wrote: > On Monday, September 15, 2003, at 11:03 AM, Steve Purkis wrote: > >> Hi all, >> >> When you update the 'dist_version_from' file *after* running >> Build.PL, the 'dist' action builds a tarball for the old version >> (which seems wrong to me). Perhaps it should check for a new >> $VERSION and rebuild the cache if it has changed? >> > > Yeah, this is known behavior (though perhaps not to anyone but me?). > The Build.PL step solidifies various configuration information, then > the subsequent steps do everything based on this configuration. I've noticed that - for example if a Build.PL ever changes, running ./Build <whatever> doesn't trigger a rebuild of the Build script like MakeMaker's Makefiles did. > I think you're probably right about the solution, though I think maybe > the user should have to manually do the update after we give a > warning. Otherwise we may end up losing any parameters the user > specified to the Build.PL invocation. > > Or we could just change the version number itself, and nothing else, > in the cache. Which makes me think maybe we shouldn't cache it there > at all... I prefer the warning option, mainly because a general solution to it will prolly cover other cases we haven't though of. And also, it makes sense to me for the version number to be in the cache. So how's about this rule: Generate a warning whenever Build.PL or a dependency changes. This also opens up the option of a 'rebuild_on_modify' flag to the constructor. Though I'm still out to lunch as to whether or not that would be useful... :) -Steve |